compiz - May 2007 - --replace for gtk-window-decorator

Hi. I noticed that the gtk-window-decorator now ignore the --replace
parameter (it always fails to load if another decorator is running).
I attach a simple patch to solve this problem.

Regards,
Pierpaolo

-- 
Pierpaolo Follia
http://madchicken.altervista.org/tech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: allow-replace-param.patch
Type: text/x-patch
Size: 629 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/compiz/attachments/20070508/bf3aaf91/allow-replace-param.bin

Pierpaolo Follia wrote:
> Hi. I noticed that the gtk-window-decorator now ignore the --replace
> parameter (it always fails to load if another decorator is running).
> I attach a simple patch to solve this problem.
> 
> Regards,
> Pierpaolo
> 
> 
> ------------------------------------------------------------------------
> 
> --- gtk-window-decorator.old	2007-05-02 15:26:01.000000000 +0200
> +++ gtk-window-decorator.c	2007-05-08 10:31:26.000000000 +0200
> @@ -6638,6 +6638,10 @@
>  
>      for (i = 0; i < argc; i++)
>      {
> +	if (strcmp (argv[i], "--replace") == 0)
> +	{
> +	    replace = TRUE;
> +	}
>  	if (strcmp (argv[i], "--minimal") == 0)
>  	{
>  	    minimal = TRUE;
> @@ -6759,7 +6763,7 @@
>  				       &dm_sn_timestamp);
>      if (status != DECOR_ACQUIRE_STATUS_SUCCESS)
>      {
> -	if (status == DECOR_ACQUIRE_STATUS_OTHER_DM_RUNNING)
> +	if (status != DECOR_ACQUIRE_STATUS_OTHER_DM_RUNNING)
>  	{
>  	    fprintf (stderr,
>  		     "%s: Could not acquire decoration manager "
> 
Hi,

i think the right fix would be 'if (status ==
DECOR_ACQUIRE_STATUS_FAILED)'.
this error code indicates that XSetSelectionOwner failed, which would match the
description.


Gerd.