John Hess
2006-Jul-08 10:40 UTC
[compiz] Patch to fix unminimizing windows on other viewports.
Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: minimize.patch Type: text/x-patch Size: 541 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20060708/be32b462/minimize.bin
David Reveman
2006-Jul-10 08:41 UTC
[compiz] Patch to fix unminimizing windows on other viewports.
On Sat, 2006-07-08 at 10:40 -0700, John Hess wrote:> Hi, I know I'm new to this list but I have something I would like to > contribute. I noticed several weeks ago a problem with the minimize > plugin causing visual artifacts when a window is unminimized on a > different viewport than the user is currently viewing. I took a look > at minimize.c and have come up with a patch that fixes this problem. > It skips the animation on invisible windows, but still fixes their > scaling so that they don't produce the artifacts. I've attached a > patch file.Does the attached patch work as well? -David -------------- next part -------------- A non-text attachment was scrubbed... Name: min-fix.diff Type: text/x-patch Size: 265 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20060710/47c29315/min-fix.bin
John Hess
2006-Jul-10 09:43 UTC
Fwd: [compiz] Patch to fix unminimizing windows on other viewports.
Sorry, unfortunately it doesn't fix it. The problem is that the section you added it to doesn't execute if w->invisible is true, and so if a window is on another viewport then the window never gets it's scaling fixed. -- .: Animacide :. On 7/10/06, David Reveman <davidr@novell.com> wrote:> > On Sat, 2006-07-08 at 10:40 -0700, John Hess wrote: > > Hi, I know I'm new to this list but I have something I would like to > > contribute. I noticed several weeks ago a problem with the minimize > > plugin causing visual artifacts when a window is unminimized on a > > different viewport than the user is currently viewing. I took a look > > at minimize.c and have come up with a patch that fixes this problem. > > It skips the animation on invisible windows, but still fixes their > > scaling so that they don't produce the artifacts. I've attached a > > patch file. > > Does the attached patch work as well? > > -David > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.freedesktop.org/archives/compiz/attachments/20060710/6d20c606/attachment.htm