> On 2020-07-12 05:57, Mogens Kjaer wrote: >> On 7/10/20 4:10 PM, Simon Matter via CentOS wrote: >>> Thanks for the tool, I've created RPMs of it: >>> >>> http://www.invoca.ch/pub/packages/hexpeek/ >> >> The package generates a symlink /usr/bin/hexedit to /usr/bin/hexpeek, >> but this is in conflict with the package hexedit which is in base of >> Centos 7. >> >> Mogens > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Indeed, this oversight made it into the beta release. It has already > been > removed from the current version and will not appear in future versions.I've upgraded the RPM as well. BTW: I strongly suggest to change back the assignment of BINDIR in the Makefiles. If 'realpath' doesn't exist on the build host, this is what happens when you run make: make -C src make[1]: Entering directory `/home/pkgbuild/rpmbuild/BUILD/hexpeek-v0.0.20200712b/src' rm -f /* rm: cannot remove `/bin': Is a directory rm: cannot remove `/boot': Is a directory rm: cannot remove `/cgroup': Is a directory rm: cannot remove `/dev': Is a directory rm: cannot remove `/etc': Is a directory rm: cannot remove `/home': Is a directory rm: cannot remove `/lib': Is a directory ... ... Regards, Simon
On 2020-07-13 04:04, Simon Matter via CentOS wrote:>> On 2020-07-12 05:57, Mogens Kjaer wrote: >>> On 7/10/20 4:10 PM, Simon Matter via CentOS wrote: >>>> Thanks for the tool, I've created RPMs of it: >>>> >>>> http://www.invoca.ch/pub/packages/hexpeek/ >>> >>> The package generates a symlink /usr/bin/hexedit to /usr/bin/hexpeek, >>> but this is in conflict with the package hexedit which is in base of >>> Centos 7. >>> >>> Mogens >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA512 >> >> Indeed, this oversight made it into the beta release. It has already >> been >> removed from the current version and will not appear in future >> versions. > > I've upgraded the RPM as well. > > BTW: I strongly suggest to change back the assignment of BINDIR in the > Makefiles. If 'realpath' doesn't exist on the build host, this is what > happens when you run make: > > make -C src > make[1]: Entering directory > `/home/pkgbuild/rpmbuild/BUILD/hexpeek-v0.0.20200712b/src' > rm -f /* > rm: cannot remove `/bin': Is a directory > rm: cannot remove `/boot': Is a directory > rm: cannot remove `/cgroup': Is a directory > rm: cannot remove `/dev': Is a directory > rm: cannot remove `/etc': Is a directory > rm: cannot remove `/home': Is a directory > rm: cannot remove `/lib': Is a directory > ... > ... > > Regards, > Simon-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Thank you for bringing this to my attention. I apologize for any inconvenience. I was under the impression make would terminate if a command failed, but it seems that is not true for variables set via a subshell. I will remove the dependency on realpath in the Makefiles and scripts, and implement a more robust cross-platform build solution when I get a chance. Again, thank you for testing this within the RPM framework. -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEfeRsn/lRU2hTiGbecMFr/kefAX8FAl8MrxMUHGhleHBlZWtA aGV4cGVlay5jb20ACgkQcMFr/kefAX9pnA//a1ZuU2DXtzkEc09VqPJMMXmk+/aD AfFkHXArzdMSGMLboVIx2T1CKef+/mttLyeMHJRWWyW6IQjSCKmHt+hZhCN8zlT0 gU21dU3jO7ZURBsuByV95hgjxIyRcJb8rKk/b5sQL46qKwf4EAK6TUn2jX6eeoOi ZjspxpN39vPz74sEj+flZA6lR3KFr2wr7bY7WMwRQPlyPLQLXxg2sIqAIdYkyWFt U9nkQ/ulb+aVTv827PDny0IrrzExuEmKRwQpbO6vUdK9px2X3ClHIhZi7Ox8qQj8 lYTpRWGOdRApnER/Q8HrMA7wy2YR3JOwgPS0suGDdcibRImf+rJZbUM4I3rij8CN GG6HSsMOAGLLlfLeoZb7kdyh3DtMyiU9JQK3E6eAnB0JEfGDLjkcJhF6KfqsoSsW +2v/SznnTBpR2t3MMdIFMlV5FSfy9vNQNi69rRQmlVUpv74BH8Q3H02UdgVntj0Z RBnITBwCYUF1/7xWbHqpzT9tCwGNrrLTeMtIdWDu1zF4PbeQF76jvW723QIhKkIm P7LH3MTks89NNn0h6PKsmHhpOYN2HEZ8Z60xBTsqZt1P6f56KkI3Km8RLSXOP8+F bvlJSgbIuT9HzNuAC/TY/bJUuGYN/REeSt0E3wYvM2pHdQDS2mgOuii1FsWgA/nD JF86ai5sc56YSlY=yKhP -----END PGP SIGNATURE-----
On 2020-07-13 15:01, hexpeek at hexpeek.com wrote:> On 2020-07-13 04:04, Simon Matter via CentOS wrote: >> BTW: I strongly suggest to change back the assignment of BINDIR in the >> Makefiles. >> ... >> >> Regards, >> Simon > > Thank you for bringing this to my attention. I apologize for any > inconvenience. I was under the impression make would terminate if a > command > failed, but it seems that is not true for variables set via a subshell. > > I will remove the dependency on realpath in the Makefiles and scripts, > and > implement a more robust cross-platform build solution when I get a > chance. > Again, thank you for testing this within the RPM framework.-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Simon, I made some adjustments to the Makefiles that should address this issue. I tested on a mostly vanilla CentOS 8.1 system. If you have any other issues, let me know. -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEfeRsn/lRU2hTiGbecMFr/kefAX8FAl8M0dEUHGhleHBlZWtA aGV4cGVlay5jb20ACgkQcMFr/kefAX+f1w//chHXCXZWxN2jgzuxvWbOAWObngJJ SqgE3Ts1mLUyWErHBru7AestsZQMn+3zpOgr6I0cRg22gOHWQredMrbTD9U0Un6g 2T1pOY8tpDM39SVE7LGBDZaESAjfTNJA9XvVx72SEB/Mysg3/cZ3DZtrwktc19iM boHWLCpuw0U5U0vKl2HB/aiiLRcz4tEAbzkaR0vbcKQwnq1zMW74wv8zyQubTjPe 9+XFaPkWiYb8r7+7C9GXbOUa5bQAr0cVJguY//lUa/KIH31davFgPFV9aWhRmanW DlThlac3GaR/BN0c8rZCr3GSMROiIYYzELjeZqpw/0sKPvTZJfe6vtD9B/DiJxQi zjZZ1La2913wtmPPq/xlz7K3L7NTBG7Ih8I3o09cHcWIEuM+bBYlUKZ2iiv09w9C t8qE/SAu6hgmUUo6nbIO8npT6rbvFCrT/1fRw41/C4DXNkppy4KLsvhvJBNBxW1D K4OFGkRRbYH6E8Q0RtywiiDwpGzGmOc0sayHrgAQjC8v21dL7gQABB6DwTirTafs Ph8wV/xDs0IhHksZ+qS2dS856txuqldrK/p6eJNCnoeSvmHGG9Sy/Agjc3wpWjqV iDq2SJaRhqjnHyddbRbsN80NnDtiDxVWsAFvJXRYNFmGCDBfBT5IWlxlaYlqWq0j 0P7IVfc1Xmqn5xs=sx0H -----END PGP SIGNATURE-----