Liu Bo
2014-May-12 04:47 UTC
[PATCH] Btrfs: mark mapping with error flag to report errors to userspace
According to commit 865ffef3797da2cac85b3354b5b6050dc9660978
(fs: fix fsync() error reporting),
it's not stable to just check error pages because pages can be
truncated or invalidated, we should also mark mapping with error
flag so that a later fsync can catch the error.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
fs/btrfs/extent_io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 80be17c..d7c7813 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2367,6 +2367,7 @@ int end_extent_writepage(struct page *page, int err, u64
start, u64 end)
if (!uptodate) {
ClearPageUptodate(page);
SetPageError(page);
+ mapping_set_error(page->mapping, ret);
}
return 0;
}
@@ -3368,6 +3369,8 @@ done:
set_page_writeback(page);
end_page_writeback(page);
}
+ if (PageError(page))
+ mapping_set_error(page->mapping, ret);
unlock_page(page);
done_unlocked:
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html