Btrfs devel - Oct 2013 - [PATCH v2] btrfs: Remove useless variable in write_ctree_super()

The function write_ctree_super() in disk-io.c uses variable ret to return
the result of function write_all_supers(). Since, this variable serves
no purpose, hence the patch removes it and returns the call of the
called function.

Reviewed-by: Zach Brown <zab@redhat.com>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This patch fixes the following issues of the previous revision-
Change Subject line

 fs/btrfs/disk-io.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 25fb77a..cc95d55 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3425,10 +3425,7 @@ static int write_all_supers(struct btrfs_root *root, int
max_mirrors)
 int write_ctree_super(struct btrfs_trans_handle *trans,
 		      struct btrfs_root *root, int max_mirrors)
 {
-	int ret;
-
-	ret = write_all_supers(root, max_mirrors);
-	return ret;
+	return write_all_supers(root, max_mirrors);
 }
 
 /* Drop a fs root from the radix tree and free it. */
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Thu, Oct 31, 2013 at 04:50:42PM +0530, Rashika Kheria
wrote:
> The function write_ctree_super() in disk-io.c uses variable ret to return
> the result of function write_all_supers(). Since, this variable serves
> no purpose, hence the patch removes it and returns the call of the
> called function.
> 
> Reviewed-by: Zach Brown <zab@redhat.com>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

(Also, in general, Reviewed-by should go after Signed-off-by.)
> ---
> 
> This patch fixes the following issues of the previous revision-
> Change Subject line
> 
>  fs/btrfs/disk-io.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 25fb77a..cc95d55 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3425,10 +3425,7 @@ static int write_all_supers(struct btrfs_root *root,
int max_mirrors)
>  int write_ctree_super(struct btrfs_trans_handle *trans,
>  		      struct btrfs_root *root, int max_mirrors)
>  {
> -	int ret;
> -
> -	ret = write_all_supers(root, max_mirrors);
> -	return ret;
> +	return write_all_supers(root, max_mirrors);
>  }
>  
>  /* Drop a fs root from the radix tree and free it. */
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html