Josef Bacik
2013-Oct-25 20:20 UTC
[PATCH] Btrfs: do not bug_on if we try to cow a free space cache inode
We can just return an error and we''ll bail out properly. We still want
to catch
this case to make sure we don''t have a bug somewhere, so just warn if
this pops
up. Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
fs/btrfs/inode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 961ae6f..db6e11f 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -843,7 +843,10 @@ static noinline int cow_file_range(struct inode *inode,
struct extent_map_tree *em_tree = &BTRFS_I(inode)->extent_tree;
int ret = 0;
- BUG_ON(btrfs_is_free_space_inode(inode));
+ if (btrfs_is_free_space_inode(inode)) {
+ WARN_ON_ONCE(1);
+ return -EINVAL;
+ }
num_bytes = ALIGN(end - start + 1, blocksize);
num_bytes = max(blocksize, num_bytes);
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Maybe Matching Threads
- [PATCH] fix uncheck memory allocations
- [PATCH 1/5] Btrfs: fix joining the same transaction handler more than 2 times
- [PATCH 1/2] btrfs: document where we use BUG_ON instead of error handling
- [PATCH 3/4] update nodatacow code
- [PATCH] Btrfs: proper metadata -ENOSPC handling
