I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok to mkfs an entire device. We need -F so it doesn''t ask this question. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- tests/btrfs/012 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/btrfs/012 b/tests/btrfs/012 index de90149..f7e5da5 100755 --- a/tests/btrfs/012 +++ b/tests/btrfs/012 @@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck rm -f $seqres.full # Create & populate an ext4 filesystem -$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \ +$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \ _notrun "Could not create ext4 filesystem" # Manual mount so we don''t use -t btrfs or selinux context mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Sandeen
2013-Oct-21 19:59 UTC
Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
On 10/21/13 11:05 AM, Josef Bacik wrote:> I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok > to mkfs an entire device. We need -F so it doesn''t ask this question. Thanks, > > Signed-off-by: Josef Bacik <jbacik@fusionio.com>Reviewed-by: Eric Sandeen <sandeen@redhat.com>> --- > tests/btrfs/012 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/btrfs/012 b/tests/btrfs/012 > index de90149..f7e5da5 100755 > --- a/tests/btrfs/012 > +++ b/tests/btrfs/012 > @@ -65,7 +65,7 @@ _require_command $E2FSCK_PROG e2fsck > rm -f $seqres.full > > # Create & populate an ext4 filesystem > -$MKFS_EXT4_PROG -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \ > +$MKFS_EXT4_PROG -F -b 4096 $SCRATCH_DEV > $seqres.full 2>&1 || \ > _notrun "Could not create ext4 filesystem" > # Manual mount so we don''t use -t btrfs or selinux context > mount -t ext4 $SCRATCH_DEV $SCRATCH_MNT >_______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
Rich Johnston
2013-Oct-22 21:19 UTC
Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012
This has been committed.
Thanks
--Rich
commit 0c6fb9f3acb4bca2c4abebaf92ed5bb48472cae0
Author: Josef Bacik <jbacik@fusionio.com>
Date: Mon Oct 21 16:05:16 2013 +0000
xfstests: use -F for mkfs.ext4 in btrfs/012
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs