Wang Shilong
2013-Sep-01 06:15 UTC
Re: Btrfs: separate out tests into their own directory V2
Hello, Using checkpatch.pl, i get the following warnings(errors):
WARNING: kfree(NULL) is safe this check is probably not required
#132: FILE: fs/btrfs/free-space-cache.c:3035:
+ if (map)
+ kfree(map);
WARNING: line over 80 characters
#882: FILE: fs/btrfs/tests/free-space-tests.c:211:
+ ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 1 * 1024 * 1024, 1);
WARNING: line over 80 characters
#927: FILE: fs/btrfs/tests/free-space-tests.c:256:
+ ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 4 * 1024 * 1024, 1);
WARNING: line over 80 characters
#947: FILE: fs/btrfs/tests/free-space-tests.c:276:
+ ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 4 * 1024 * 1024, 1);
WARNING: line over 80 characters
#953: FILE: fs/btrfs/tests/free-space-tests.c:282:
+ ret = test_add_free_space_entry(cache, 2 * 1024 * 1024, 2 * 1024 * 1024, 0);
WARNING: line over 80 characters
#1016: FILE: fs/btrfs/tests/free-space-tests.c:345:
+ ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 2 * 1024 * 1024, 1);
WARNING: line over 80 characters
#1022: FILE: fs/btrfs/tests/free-space-tests.c:351:
+ ret = test_add_free_space_entry(cache, 3 * 1024 * 1024, 1 * 1024 * 1024, 0);
WARNING: line over 80 characters
#1030: FILE: fs/btrfs/tests/free-space-tests.c:359:
+ test_msg("Error removing bitmap and extent overlapping %d\n", ret);
total: 0 errors, 8 warnings, 997 lines checked
patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Thanks, Wang
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Wang Shilong
2013-Sep-02 01:13 UTC
Re: Btrfs: separate out tests into their own directory V2
Sorry, please ignore this thread... Thanks, wang On 09/01/2013 02:15 PM, Wang Shilong wrote:> Hello, Using checkpatch.pl, i get the following warnings(errors): > WARNING: kfree(NULL) is safe this check is probably not required > #132: FILE: fs/btrfs/free-space-cache.c:3035: > + if (map) > + kfree(map); > > WARNING: line over 80 characters > #882: FILE: fs/btrfs/tests/free-space-tests.c:211: > + ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 1 * 1024 * 1024, 1); > > WARNING: line over 80 characters > #927: FILE: fs/btrfs/tests/free-space-tests.c:256: > + ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 4 * 1024 * 1024, 1); > > WARNING: line over 80 characters > #947: FILE: fs/btrfs/tests/free-space-tests.c:276: > + ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 4 * 1024 * 1024, 1); > > WARNING: line over 80 characters > #953: FILE: fs/btrfs/tests/free-space-tests.c:282: > + ret = test_add_free_space_entry(cache, 2 * 1024 * 1024, 2 * 1024 * 1024, 0); > > WARNING: line over 80 characters > #1016: FILE: fs/btrfs/tests/free-space-tests.c:345: > + ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 2 * 1024 * 1024, 1); > > WARNING: line over 80 characters > #1022: FILE: fs/btrfs/tests/free-space-tests.c:351: > + ret = test_add_free_space_entry(cache, 3 * 1024 * 1024, 1 * 1024 * 1024, 0); > > WARNING: line over 80 characters > #1030: FILE: fs/btrfs/tests/free-space-tests.c:359: > + test_msg("Error removing bitmap and extent overlapping %d\n", ret); > > total: 0 errors, 8 warnings, 997 lines checked > > patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Thanks, Wang > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html