Wang Shilong
2013-Sep-01 06:15 UTC
Re: btrfs-progs: v3, move out print in cmd_df to another function
Hello, Using checkpatch.pl, i get the following warnings(errors): ERROR: "foo * bar" should be "foo *bar" #37: FILE: cmds-filesystem.c:47: +static char * group_type_str(u64 flag) ERROR: "foo * bar" should be "foo *bar" #69: FILE: cmds-filesystem.c:63: +static char * group_profile_str(u64 flag) total: 2 errors, 0 warnings, 229 lines checked patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Thanks, Wang -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Anand Jain
2013-Sep-02 02:58 UTC
Re: btrfs-progs: v3, move out print in cmd_df to another function
Wang, kindly note that this was fixed in v4. Anand On 09/01/2013 02:15 PM, Wang Shilong wrote:> Hello, Using checkpatch.pl, i get the following warnings(errors): > ERROR: "foo * bar" should be "foo *bar" > #37: FILE: cmds-filesystem.c:47: > +static char * group_type_str(u64 flag) > > ERROR: "foo * bar" should be "foo *bar" > #69: FILE: cmds-filesystem.c:63: > +static char * group_profile_str(u64 flag) > > total: 2 errors, 0 warnings, 229 lines checked > > patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Thanks, Wang > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wang Shilong
2013-Sep-02 03:00 UTC
Re: btrfs-progs: v3, move out print in cmd_df to another function
On 09/02/2013 10:58 AM, Anand Jain wrote:> > Wang, kindly note that this was fixed in v4.Yeah...This is sent by my shell script by accident, I have fixed it and it won''t send the repeated message again. Thanks for reminding .. ^_^> > Anand > > > On 09/01/2013 02:15 PM, Wang Shilong wrote: >> Hello, Using checkpatch.pl, i get the following warnings(errors): >> ERROR: "foo * bar" should be "foo *bar" >> #37: FILE: cmds-filesystem.c:47: >> +static char * group_type_str(u64 flag) >> >> ERROR: "foo * bar" should be "foo *bar" >> #69: FILE: cmds-filesystem.c:63: >> +static char * group_profile_str(u64 flag) >> >> total: 2 errors, 0 warnings, 229 lines checked >> >> patch has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. >> >> Thanks, Wang >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-btrfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html