Filipe David Borba Manana
2013-Jul-09 20:31 UTC
[PATCH] Btrfs-progs: update usage message for cmds-restore
Mention that a target path argument is mandatory unless the -l option is supplied. Also mention about the existence of the -l option, which was previously not announced. $ btrfs restore -v /dev/sdb3 usage: btrfs restore [options] <device> Try to restore files from a damaged filesystem (unmounted) -s get snapshots -v verbose -i ignore errors -o overwrite -t tree location -f <offset> filesystem location -u <block> super mirror -d find dir $ echo $? 129 After specifying a target path, the command works as expected: $ btrfs restore -v /dev/sdb3 files2/ Restoring files2/file1 Done searching $ echo $? 0 Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com> --- cmds-restore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmds-restore.c b/cmds-restore.c index eca528d..70ebb9f 100644 --- a/cmds-restore.c +++ b/cmds-restore.c @@ -956,7 +956,7 @@ out: } const char * const cmd_restore_usage[] = { - "btrfs restore [options] <device>", + "btrfs restore [options] <device> <path> | btrfs restore -l <device>", "Try to restore files from a damaged filesystem (unmounted)", "", "-s get snapshots", @@ -967,6 +967,7 @@ const char * const cmd_restore_usage[] = { "-f <offset> filesystem location", "-u <block> super mirror", "-d find dir", + "-l list roots", NULL }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Anand Jain
2013-Jul-10 03:43 UTC
Re: [PATCH] Btrfs-progs: update usage message for cmds-restore
Thanks.> - "btrfs restore [options] <device>", > + "btrfs restore [options] <device> <path> | btrfs restore -l <device>",should this be rather... "btrfs restore [options] <device> <path> | -l <device>", Thanks Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Filipe David Borba Manana
2013-Jul-10 08:36 UTC
[PATCH v2] Btrfs-progs: update usage message for cmds-restore
Mention that a target path argument is mandatory unless the -l option is supplied. Also mention about the existence of the -l option, which was previously not announced. $ btrfs restore -v /dev/sdb3 usage: btrfs restore [options] <device> Try to restore files from a damaged filesystem (unmounted) -s get snapshots -v verbose -i ignore errors -o overwrite -t tree location -f <offset> filesystem location -u <block> super mirror -d find dir $ echo $? 129 After specifying a target path, the command works as expected: $ btrfs restore -v /dev/sdb3 files2/ Restoring files2/file1 Done searching $ echo $? 0 V2: Updated command synopsis by suggestion of Anand Jain. Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com> --- cmds-restore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmds-restore.c b/cmds-restore.c index eca528d..d362d79 100644 --- a/cmds-restore.c +++ b/cmds-restore.c @@ -956,7 +956,7 @@ out: } const char * const cmd_restore_usage[] = { - "btrfs restore [options] <device>", + "btrfs restore [options] <device> <path> | -l <device>", "Try to restore files from a damaged filesystem (unmounted)", "", "-s get snapshots", @@ -967,6 +967,7 @@ const char * const cmd_restore_usage[] = { "-f <offset> filesystem location", "-u <block> super mirror", "-d find dir", + "-l list roots", NULL }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html