(same as commit bb0eabc383e9a3fde7cdb02591ca88243f3e31fb) There, ''char'' is unsigned, so once assigned ''-1'' from getopt, it gets the value 255. Then, it compared to ''-1'' gives false. Signed-off-by: David Sterba <dsterba@suse.cz> --- btrfs-crc.c | 2 +- cmds-device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/btrfs-crc.c b/btrfs-crc.c index e4cda43..1990534 100644 --- a/btrfs-crc.c +++ b/btrfs-crc.c @@ -34,7 +34,7 @@ void usage(void) int main(int argc, char **argv) { - char c; + int c; unsigned long checksum = 0; char *str; char *buf; diff --git a/cmds-device.c b/cmds-device.c index 41e79d3..9e7328b 100644 --- a/cmds-device.c +++ b/cmds-device.c @@ -294,7 +294,7 @@ static int cmd_dev_stats(int argc, char **argv) int ret; int fdmnt; int i; - char c; + int c; int err = 0; __u64 flags = 0; -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html