Hi Linus, My for-linus branch has our batch of btrfs fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus We''ve been hammering away at a crc corruption as well, which I was really hoping to get into this pull. It isn''t nailed down yet, but we were finally able to get a solid way to reproduce. The only good news is it isn''t a recent regression. The most important batch of fixes in here come from Ilya. They address a regression Liu Bo found in the balance ioctls for pausing and resuming a running balance across drives. Josef''s orphan truncate patch fixes an obscure corruption we''d see during xfstests. Arne''s patches address problems with subvolume quotas. If the user destroys quota groups incorrectly the FS will refuse to mount. The rest are smaller fixes and plugs for memory leaks. Ilya Dryomov (6) commits (+94/-32): Btrfs: reorder locks and sanity checks in btrfs_ioctl_defrag (+9/-8) Btrfs: fix "mutually exclusive op is running" error code (+4/-4) Btrfs: fix a regression in balance usage filter (+8/-1) Btrfs: bring back balance pause/resume logic (+71/-17) Btrfs: fix unlock order in btrfs_ioctl_rm_dev (+1/-1) Btrfs: fix unlock order in btrfs_ioctl_resize (+1/-1) Liu Bo (4) commits (+18/-7): Btrfs: fix a bug when llseek for delalloc bytes behind prealloc extents (+14/-6) Btrfs: let allocation start from the right raid type (+1/-1) Btrfs: reset path lock state to zero (+2/-0) Btrfs: fix off-by-one in lseek (+1/-0) Miao Xie (4) commits (+15/-7): Btrfs: fix missing write access release in btrfs_ioctl_resize() (+1/-0) Btrfs: do not delete a subvolume which is in a R/O subvolume (+5/-5) Btrfs: fix resize a readonly device (+4/-2) Btrfs: disable qgroup id 0 (+5/-0) Arne Jansen (2) commits (+19/-1): Btrfs: prevent qgroup destroy when there are still relations (+12/-1) Btrfs: ignore orphan qgroup relations (+7/-0) Josef Bacik (2) commits (+39/-16): Btrfs: add orphan before truncating pagecache (+38/-15) Btrfs: set flushing if we''re limited flushing (+1/-1) Zach Brown (1) commits (+1/-0): btrfs: fix btrfs_cont_expand() freeing IS_ERR em Lukas Czerner (1) commits (+1/-1): btrfs: get the device in write mode when deleting it Eric Sandeen (1) commits (+14/-3): btrfs: update timestamps on truncate() Tsutomu Itoh (1) commits (+3/-1): Btrfs: fix memory leak in name_cache_insert() Total: (22) commits fs/btrfs/extent-tree.c | 6 ++- fs/btrfs/file.c | 10 ++-- fs/btrfs/inode.c | 82 +++++++++++++++++++++++-------- fs/btrfs/ioctl.c | 129 +++++++++++++++++++++++++++++++++++-------------- fs/btrfs/qgroup.c | 20 +++++++- fs/btrfs/send.c | 4 +- fs/btrfs/volumes.c | 21 ++++++-- 7 files changed, 204 insertions(+), 68 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 22, 2013 at 07:48:33PM -0500, Chris Mason wrote:> Hi Linus, > > My for-linus branch has our batch of btrfs fixes: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > We''ve been hammering away at a crc corruption as well, which I was > really hoping to get into this pull. It isn''t nailed down yet, but we > were finally able to get a solid way to reproduce. The only good > news is it isn''t a recent regression. > > The most important batch of fixes in here come from Ilya. They address > a regression Liu Bo found in the balance ioctls for pausing and resuming > a running balance across drives. > > Josef''s orphan truncate patch fixes an obscure corruption we''d see > during xfstests. > > Arne''s patches address problems with subvolume quotas. If the user > destroys quota groups incorrectly the FS will refuse to mount. > > The rest are smaller fixes and plugs for memory leaks.Hi, Any chance to get these in this round? I think they''re good fixes, a memory leak and a warning fix, both are got from xfstests. - Btrfs: use right range to find checksum for compressed extents https://patchwork.kernel.org/patch/1937031/ - Btrfs: fix memory leak on extent map after fsync https://patchwork.kernel.org/patch/1946561/ thanks, liubo> > Ilya Dryomov (6) commits (+94/-32): > Btrfs: reorder locks and sanity checks in btrfs_ioctl_defrag (+9/-8) > Btrfs: fix "mutually exclusive op is running" error code (+4/-4) > Btrfs: fix a regression in balance usage filter (+8/-1) > Btrfs: bring back balance pause/resume logic (+71/-17) > Btrfs: fix unlock order in btrfs_ioctl_rm_dev (+1/-1) > Btrfs: fix unlock order in btrfs_ioctl_resize (+1/-1) > > Liu Bo (4) commits (+18/-7): > Btrfs: fix a bug when llseek for delalloc bytes behind prealloc extents (+14/-6) > Btrfs: let allocation start from the right raid type (+1/-1) > Btrfs: reset path lock state to zero (+2/-0) > Btrfs: fix off-by-one in lseek (+1/-0) > > Miao Xie (4) commits (+15/-7): > Btrfs: fix missing write access release in btrfs_ioctl_resize() (+1/-0) > Btrfs: do not delete a subvolume which is in a R/O subvolume (+5/-5) > Btrfs: fix resize a readonly device (+4/-2) > Btrfs: disable qgroup id 0 (+5/-0) > > Arne Jansen (2) commits (+19/-1): > Btrfs: prevent qgroup destroy when there are still relations (+12/-1) > Btrfs: ignore orphan qgroup relations (+7/-0) > > Josef Bacik (2) commits (+39/-16): > Btrfs: add orphan before truncating pagecache (+38/-15) > Btrfs: set flushing if we''re limited flushing (+1/-1) > > Zach Brown (1) commits (+1/-0): > btrfs: fix btrfs_cont_expand() freeing IS_ERR em > > Lukas Czerner (1) commits (+1/-1): > btrfs: get the device in write mode when deleting it > > Eric Sandeen (1) commits (+14/-3): > btrfs: update timestamps on truncate() > > Tsutomu Itoh (1) commits (+3/-1): > Btrfs: fix memory leak in name_cache_insert() > > Total: (22) commits > > fs/btrfs/extent-tree.c | 6 ++- > fs/btrfs/file.c | 10 ++-- > fs/btrfs/inode.c | 82 +++++++++++++++++++++++-------- > fs/btrfs/ioctl.c | 129 +++++++++++++++++++++++++++++++++++-------------- > fs/btrfs/qgroup.c | 20 +++++++- > fs/btrfs/send.c | 4 +- > fs/btrfs/volumes.c | 21 ++++++-- > 7 files changed, 204 insertions(+), 68 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 22, 2013 at 06:28:21PM -0700, Liu Bo wrote:> On Tue, Jan 22, 2013 at 07:48:33PM -0500, Chris Mason wrote: > > Hi Linus, > > > > My for-linus branch has our batch of btrfs fixes: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > > > We''ve been hammering away at a crc corruption as well, which I was > > really hoping to get into this pull. It isn''t nailed down yet, but we > > were finally able to get a solid way to reproduce. The only good > > news is it isn''t a recent regression. > > > > The most important batch of fixes in here come from Ilya. They address > > a regression Liu Bo found in the balance ioctls for pausing and resuming > > a running balance across drives. > > > > Josef''s orphan truncate patch fixes an obscure corruption we''d see > > during xfstests. > > > > Arne''s patches address problems with subvolume quotas. If the user > > destroys quota groups incorrectly the FS will refuse to mount. > > > > The rest are smaller fixes and plugs for memory leaks. > > Hi, > > Any chance to get these in this round? I think they''re good fixes, > a memory leak and a warning fix, both are got from xfstests.I''ll get these tested in the next pull. -chris
On Tue, Jan 22, 2013 at 05:48:33PM -0700, Chris Mason wrote:> Hi Linus, > > My for-linus branch has our batch of btrfs fixes: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > We''ve been hammering away at a crc corruption as well, which I was > really hoping to get into this pull. It isn''t nailed down yet, but we > were finally able to get a solid way to reproduce. The only good > news is it isn''t a recent regression.Update on this, we''ve tracked down the crc errors and are doing final checks on the patches. Linus are you planning on taking this pull? If not I can just fold the new stuff into a bigger request. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 24, 2013 at 1:52 PM, Chris Mason <chris.mason@fusionio.com> wrote:> > Update on this, we''ve tracked down the crc errors and are doing final > checks on the patches. Linus are you planning on taking this pull? If > not I can just fold the new stuff into a bigger request.If you have them basically ready, add them to this, I haven''t pulled yet. So I''ll just ignore this and wait for another pull request. Linus
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus We''ve got corner cases for updating i_size that ceph was hitting, error handling for quotas when we run out of space, a very subtle snapshot deletion race, a crash while removing devices, and one deadlock between subvolume creation and the sb_internal code (thanks lockdep). Josef Bacik (3) commits (+12/-4): Btrfs: do not merge logged extents if we''ve removed them from the tree (+2/-1) Btrfs: fix possible stale data exposure (+1/-1) Btrfs: fix missing i_size update (+9/-2) Miao Xie (2) commits (+21/-9): Btrfs: fix missing release of the space/qgroup reservation in start_transaction() (+19/-8) Btrfs: fix wrong sync_writers decrement in btrfs_file_aio_write() (+2/-1) Jan Schmidt (1) commits (+10/-12): Btrfs: fix EDQUOT handling in btrfs_delalloc_reserve_metadata Liu Bo (1) commits (+38/-9): Btrfs: fix race between snapshot deletion and getting inode Chris Mason (1) commits (+4/-1): Btrfs: move d_instantiate outside the transaction during mksubvol Eric Sandeen (1) commits (+2/-1): btrfs: don''t try to notify udev about missing devices Total: (9) commits fs/btrfs/extent-tree.c | 22 ++++++++++------------ fs/btrfs/extent_map.c | 3 ++- fs/btrfs/file.c | 25 ++++++++++++++++++++----- fs/btrfs/ioctl.c | 5 ++++- fs/btrfs/ordered-data.c | 13 ++++++++++--- fs/btrfs/scrub.c | 25 ++++++++++++++++++++----- fs/btrfs/transaction.c | 27 +++++++++++++++++++-------- fs/btrfs/volumes.c | 3 ++- 8 files changed, 87 insertions(+), 36 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ sorry, my lbdb seems to really like linux-kernel@vger.kerrnel.org, fixed for real this time ] Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus We''ve got corner cases for updating i_size that ceph was hitting, error handling for quotas when we run out of space, a very subtle snapshot deletion race, a crash while removing devices, and one deadlock between subvolume creation and the sb_internal code (thanks lockdep). Josef Bacik (3) commits (+12/-4): Btrfs: do not merge logged extents if we''ve removed them from the tree (+2/-1) Btrfs: fix possible stale data exposure (+1/-1) Btrfs: fix missing i_size update (+9/-2) Miao Xie (2) commits (+21/-9): Btrfs: fix missing release of the space/qgroup reservation in start_transaction() (+19/-8) Btrfs: fix wrong sync_writers decrement in btrfs_file_aio_write() (+2/-1) Jan Schmidt (1) commits (+10/-12): Btrfs: fix EDQUOT handling in btrfs_delalloc_reserve_metadata Liu Bo (1) commits (+38/-9): Btrfs: fix race between snapshot deletion and getting inode Chris Mason (1) commits (+4/-1): Btrfs: move d_instantiate outside the transaction during mksubvol Eric Sandeen (1) commits (+2/-1): btrfs: don''t try to notify udev about missing devices Total: (9) commits fs/btrfs/extent-tree.c | 22 ++++++++++------------ fs/btrfs/extent_map.c | 3 ++- fs/btrfs/file.c | 25 ++++++++++++++++++++----- fs/btrfs/ioctl.c | 5 ++++- fs/btrfs/ordered-data.c | 13 ++++++++++--- fs/btrfs/scrub.c | 25 ++++++++++++++++++++----- fs/btrfs/transaction.c | 27 +++++++++++++++++++-------- fs/btrfs/volumes.c | 3 ++- 8 files changed, 87 insertions(+), 36 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html