There is a typo (?) in inode.c (git) i guess the "int limit = 10 * 1024 * 1042;" should be "int limit = 10 * 1024 * 1024;" instead Could developer fix this typo? static int cow_file_range_async(struct inode *inode, struct page *locked_page, u64 start, u64 end, int *page_started, unsigned long *nr_written) { struct async_cow *async_cow; struct btrfs_root *root = BTRFS_I(inode)->root; unsigned long nr_pages; u64 cur_end; int limit = 10 * 1024 * 1042; clear_extent_bit(&BTRFS_I(inode)->io_tree, start, end, EXTENT_LOCKED, 1, 0, NULL, GFP_NOFS); while (start < end) { async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS); BUG_ON(!async_cow); async_cow->inode = inode; async_cow->root = root; async_cow->locked_page = locked_page; async_cow->start = start; -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote:> There is a typo (?) in inode.c (git)What''s the top commit and what git tree? This has been fixed in 3.6-rc4 via 287082b0bd10060e9c6b32ed9605174ddf2f672a david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/26/2012 11:23 PM, David Sterba wrote:> On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote: >> There is a typo (?) in inode.c (git) > What''s the top commit and what git tree? > > This has been fixed in 3.6-rc4 via > 287082b0bd10060e9c6b32ed9605174ddf2f672a > > david >This mistake is in http://git.kernel.org/?p=linux/kernel/git/mason/linux-btrfs.git;a=summary -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 27, 2012 at 05:04:02AM +0800, ching wrote:> On 09/26/2012 11:23 PM, David Sterba wrote: > > On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote: > >> There is a typo (?) in inode.c (git) > > What''s the top commit and what git tree? > > > > This has been fixed in 3.6-rc4 via > > 287082b0bd10060e9c6b32ed9605174ddf2f672a > > > This mistake is in > > http://git.kernel.org/?p=linux/kernel/git/mason/linux-btrfs.git;a=summaryI see, this is because the fix was merged into linus'' tree via the trivial tree. If unsure, you may want to check btrfs-next first. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html