We do not need to do anything special to freeze or unfreeze, it''s all
taken
care of by the generic work, and what we currently have is wrong anyway
since we shouldn''t be returnning to userspace with mutexes held anyway.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
fs/btrfs/super.c | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 5aa3b81..fa80e2d 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1509,22 +1509,6 @@ static long btrfs_control_ioctl(struct file *file,
unsigned int cmd,
return ret;
}
-static int btrfs_freeze(struct super_block *sb)
-{
- struct btrfs_fs_info *fs_info = btrfs_sb(sb);
- mutex_lock(&fs_info->transaction_kthread_mutex);
- mutex_lock(&fs_info->cleaner_mutex);
- return 0;
-}
-
-static int btrfs_unfreeze(struct super_block *sb)
-{
- struct btrfs_fs_info *fs_info = btrfs_sb(sb);
- mutex_unlock(&fs_info->cleaner_mutex);
- mutex_unlock(&fs_info->transaction_kthread_mutex);
- return 0;
-}
-
static int btrfs_show_devname(struct seq_file *m, struct dentry *root)
{
struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb);
@@ -1570,8 +1554,6 @@ static const struct super_operations btrfs_super_ops = {
.destroy_inode = btrfs_destroy_inode,
.statfs = btrfs_statfs,
.remount_fs = btrfs_remount,
- .freeze_fs = btrfs_freeze,
- .unfreeze_fs = btrfs_unfreeze,
};
static const struct file_operations btrfs_ctl_fops = {
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Josef Bacik
2012-Sep-14 18:02 UTC
Re: [PATCH] Btrfs: remove our ->freeze_fs and ->unfreeze_fs
On Fri, Sep 14, 2012 at 12:00:37PM -0600, Josef Bacik wrote:> We do not need to do anything special to freeze or unfreeze, it''s all taken > care of by the generic work, and what we currently have is wrong anyway > since we shouldn''t be returnning to userspace with mutexes held anyway. > Thanks, >Hrm ignore this, apparently we have to at least have a freeze_fs in order for freeze to work. Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html