# mount -t btrfs /dev/sda7 /mnt
# dd if=/dev/zero of=/mnt/src bs=10K count=1
# sync
# clone 4K from /mnt/src to /mnt/dst
kernel BUG at fs/btrfs/delayed-inode.c:1693!
We should reverse space for both file extent item insertion and
inode update.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
fs/btrfs/ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 0b980af..05af14c 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2314,7 +2314,7 @@ static noinline long btrfs_ioctl_clone(struct file *file,
unsigned long srcfd,
else
new_key.offset = destoff;
- trans = btrfs_start_transaction(root, 1);
+ trans = btrfs_start_transaction(root, 2);
if (IS_ERR(trans)) {
ret = PTR_ERR(trans);
goto out;
--
1.7.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
# mount -t btrfs /dev/sda7 /mnt
# dd if=/dev/zero of=/mnt/src bs=10K count=1
# sync
# clone 4K from /mnt/src to /mnt/dst
kernel BUG at fs/btrfs/delayed-inode.c:1693!
We should reserve space for both file extent item insertion and
inode update.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
v2:
- fix typo: s/reverse/reserve
---
fs/btrfs/ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 0b980af..05af14c 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2314,7 +2314,7 @@ static noinline long btrfs_ioctl_clone(struct file *file,
unsigned long srcfd,
else
new_key.offset = destoff;
- trans = btrfs_start_transaction(root, 1);
+ trans = btrfs_start_transaction(root, 2);
if (IS_ERR(trans)) {
ret = PTR_ERR(trans);
goto out;
-- 1.7.3.1 --
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig
2011-Jul-29 09:32 UTC
Re: [PATCH v2] Btrfs: reserve enough space for file clone
On Fri, Jul 29, 2011 at 04:07:36PM +0800, Li Zefan wrote:> # mount -t btrfs /dev/sda7 /mnt > # dd if=/dev/zero of=/mnt/src bs=10K count=1 > # sync > # clone 4K from /mnt/src to /mnt/dst > > kernel BUG at fs/btrfs/delayed-inode.c:1693!Sounds like a regression test you should add to xfstests. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html