Btrfs devel - Jul 2011 - sign a bug in “set_extent_bit”

hi 

In the end part of “set_extent_bit”，I found when err occurs ，there is no operate
to free "prealloc" which have been allocated in
"alloc_extent_state_atomic"
this may lead a menory leak when "set_state_bits" failed.
err = set_state_bits(tree, prealloc, &bits);

if (err) {
prealloc = NULL;
goto out; // this direct will do nothing because prealloc=NULL.
}
wish your reply.
thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Qiang Zhu wrote:
> hi 
> 
> In the end part of “set_extent_bit”，I found when err occurs ，there is no
operate to free "prealloc" which have been allocated in
"alloc_extent_state_atomic"
> this may lead a menory leak when "set_state_bits" failed.
No, it won''t. ''prealloc'' has been inserted into
rbtree before set_state_bits()
is called().
> err = set_state_bits(tree, prealloc, &bits);
> 
> if (err) {
> prealloc = NULL;
> goto out; // this direct will do nothing because prealloc=NULL.
> }
> wish your reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html