Hi Chris,
please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/arne/btrfs-unstable-arne.git
for-chris
It contains the 2 commits
Arne Jansen (1):
btrfs: scrub: errors in tree enumeration
Li Zefan (1):
Btrfs: avoid stack bloat in btrfs_ioctl_fs_info()
It also reverts
commit cb25c2ea6a79702ab7895b873c6c43e0d3bc3c72
Author: Josef Bacik <josef@redhat.com>
Date: Wed May 11 12:17:34 2011 -0400
Btrfs: map the node block when looking for readahead targets
because it breaks readahead and with it scrub. This went unnoticed,
because another commit disabled reada in many calling sites. Scrub
is a heavy user of reada.
Thanks,
Arne
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/08/2011 04:58 AM, Arne Jansen wrote:> Hi Chris, > > please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/arne/btrfs-unstable-arne.git > for-chris > > It contains the 2 commits > > Arne Jansen (1): > btrfs: scrub: errors in tree enumeration > > Li Zefan (1): > Btrfs: avoid stack bloat in btrfs_ioctl_fs_info() > > It also reverts > > commit cb25c2ea6a79702ab7895b873c6c43e0d3bc3c72 > Author: Josef Bacik <josef@redhat.com> > Date: Wed May 11 12:17:34 2011 -0400 > > Btrfs: map the node block when looking for readahead targets > > because it breaks readahead and with it scrub. This went unnoticed, > because another commit disabled reada in many calling sites. Scrub > is a heavy user of reada. >NAK, this commit isn''t wrong, something else is happening. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Excerpts from Josef Bacik''s message of 2011-06-08 09:25:57 -0400:> On 06/08/2011 04:58 AM, Arne Jansen wrote: > > Hi Chris, > > > > please pull from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/arne/btrfs-unstable-arne.git > > for-chris > > > > It contains the 2 commits > > > > Arne Jansen (1): > > btrfs: scrub: errors in tree enumeration > > > > Li Zefan (1): > > Btrfs: avoid stack bloat in btrfs_ioctl_fs_info()Please leave off commits from others unless you somehow depend on them ;) I''ll pull in the stack bloat patch separately. re: the revert, it sounds like the lack of locking is causing trouble. We''ll have to figure something else out. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08.06.2011 19:54, Chris Mason wrote:> Excerpts from Josef Bacik''s message of 2011-06-08 09:25:57 -0400: >> On 06/08/2011 04:58 AM, Arne Jansen wrote: >>> Hi Chris, >>> >>> please pull from >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/arne/btrfs-unstable-arne.git >>> for-chris >>> >>> It contains the 2 commits >>> >>> Arne Jansen (1): >>> btrfs: scrub: errors in tree enumeration >>> >>> Li Zefan (1): >>> Btrfs: avoid stack bloat in btrfs_ioctl_fs_info() > > Please leave off commits from others unless you somehow depend on > them ;) I''ll pull in the stack bloat patch separately.ok, will not do it again ;)> > re: the revert, it sounds like the lack of locking is causing trouble. > We''ll have to figure something else out.Josef sent a patch for that. It fixes the crashes I saw, so please take it instead. The branch is now updated to contain only the tree enumeration correction, now even more correct. -Arne> > -chris-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html