Hi, compiling the latest checkout of btrfs-progs-git, I still get the compiler error Miao Xie reported[0] in March, along with a patch: cc1: warnings being treated as errors btrfs-list.c: In function ''ino_resolve'': btrfs-list.c:511: warning: implicit declaration of function ''strndup'' btrfs-list.c:511: warning: incompatible implicit declaration of built-in function ''strndup'' make: *** [btrfs-list.o] Error 1 I''m on Debian/stable (gcc 4.3.2-1.1, glibc-2.7), the patch from Miao Xie resolved this issue. Is there a reason it''s not in git yet? Thanks, Christian. [0] https://patchwork.kernel.org/patch/88224/ http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg04610.html -- BOFH excuse #374: It''s the InterNIC''s fault. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, I''ve sent this (see below) a while ago, the patch from Miao Xie is from March even. I still cannot compile btrfs-progs without his fix. Please include this fix into the repo. Thanks, Christian. Christian Kujau wrote on 2010-04-22 24:50 :> compiling the latest checkout of btrfs-progs-git, I still get the compiler > error Miao Xie reported[0] in March, along with a patch: > > cc1: warnings being treated as errors > btrfs-list.c: In function ''ino_resolve'': > btrfs-list.c:511: warning: implicit declaration of function ''strndup'' > btrfs-list.c:511: warning: incompatible implicit declaration of built-in > function ''strndup'' > make: *** [btrfs-list.o] Error 1 > > I''m on Debian/stable (gcc 4.3.2-1.1, glibc-2.7), the patch from Miao Xie > resolved this issue. Is there a reason it''s not in git yet? > > Thanks, > Christian. > > [0] https://patchwork.kernel.org/patch/88224/ > http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg04610.htmldiff --git a/btrfs-list.c b/btrfs-list.c index 7741705..9dedb5d 100644 --- a/btrfs-list.c +++ b/btrfs-list.c @@ -16,6 +16,7 @@ * Boston, MA 021110-1307, USA. */ +#define _GNU_SOURCE #ifndef __CHECKER__ #include <sys/ioctl.h> #include <sys/mount.h> diff --git a/btrfs.c b/btrfs.c index ab5e57f..46314cf 100644 --- a/btrfs.c +++ b/btrfs.c @@ -14,7 +14,7 @@ * Boston, MA 021110-1307, USA. */ - +#define _GNU_SOURCE #include <stdio.h> #include <stdlib.h> #include <string.h> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
ping? (is nobody using btrfs-progs any more?) On Fri, 14 May 2010 at 06:27, Christian Kujau wrote:> Hi, > > I''ve sent this (see below) a while ago, the patch from Miao Xie is from > March even. I still cannot compile btrfs-progs without his fix. Please > include this fix into the repo. > > Thanks, > Christian. > > Christian Kujau wrote on 2010-04-22 24:50 : > > compiling the latest checkout of btrfs-progs-git, I still get the compiler > > error Miao Xie reported[0] in March, along with a patch: > > > > cc1: warnings being treated as errors > > btrfs-list.c: In function ''ino_resolve'': > > btrfs-list.c:511: warning: implicit declaration of function ''strndup'' > > btrfs-list.c:511: warning: incompatible implicit declaration of built-in > > function ''strndup'' > > make: *** [btrfs-list.o] Error 1 > > > > I''m on Debian/stable (gcc 4.3.2-1.1, glibc-2.7), the patch from Miao Xie > > resolved this issue. Is there a reason it''s not in git yet? > > > > Thanks, > > Christian. > > > > [0] https://patchwork.kernel.org/patch/88224/ > > http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg04610.html > > diff --git a/btrfs-list.c b/btrfs-list.c > index 7741705..9dedb5d 100644 > --- a/btrfs-list.c > +++ b/btrfs-list.c > @@ -16,6 +16,7 @@ > * Boston, MA 021110-1307, USA. > */ > +#define _GNU_SOURCE > #ifndef __CHECKER__ > #include <sys/ioctl.h> > #include <sys/mount.h> > diff --git a/btrfs.c b/btrfs.c > index ab5e57f..46314cf 100644 > --- a/btrfs.c > +++ b/btrfs.c > @@ -14,7 +14,7 @@ > * Boston, MA 021110-1307, USA. > */ > - > +#define _GNU_SOURCE > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >-- BOFH excuse #11: magnetic interference from money/credit cards -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html