rb_node is never an ERR_PTR() here. This code confuses smatch. Signed-off-by: Dan Carpenter <error27@gmail.com> --- This doesn''t change anything. It''s just a cleanup. Could you load it up for linux-next? diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index 28d87ba..94668b1 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c @@ -335,10 +335,6 @@ struct extent_map *lookup_extent_mapping(struct extent_map_tree *tree, em = NULL; goto out; } - if (IS_ERR(rb_node)) { - em = ERR_PTR(PTR_ERR(rb_node)); - goto out; - } em = rb_entry(rb_node, struct extent_map, rb_node); if (end > em->start && start < extent_map_end(em)) goto found; -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html