Btrfs devel - Sep 2009 - [patch 2/2] grub-0.97: btrfs multidevice configuration support

Am Freitag 25 September 2009 00:06:40 schrieb Edward
Shishkin:
> 
Hi Edward,

I was pointed to a problem with this patch.

+static u64 scan_grub_devices(struct btrfs_device *dev,
+                            int (*discerner)(struct btrfs_device **, int),
+                            int lookup)
+{
...
+#ifdef SUPPORT_NETBOOT
+       errnum = ERR_NONE;
+       if (network_ready &&
+           !get_diskinfo(NETWORK_DRIVE, &geom)) {
+               dev->drive = NETWORK_DRIVE;
+               dev->part = 0;
+               dev->length = geom.total_sectors;
+               if (discerner(&dev, lookup)) {
+                       count++;
+                       if (lookup)
+                               goto exit;
+               }
+       }
+#endif /* SUPPORT_NETBOOT */
+ exit:
+       return count;
+}

This won''t compile since network_ready is undeclared. Why is the btrfs
code
dealing with network devices at all?

regards
  Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Johannes Hirte wrote:
> Am Freitag 25 September 2009 00:06:40 schrieb Edward Shishkin:
>   
>
> Hi Edward,
>
> I was pointed to a problem with this patch.
>
> +static u64 scan_grub_devices(struct btrfs_device *dev,
> +                            int (*discerner)(struct btrfs_device **, int),
> +                            int lookup)
> +{
> ...
> +#ifdef SUPPORT_NETBOOT
> +       errnum = ERR_NONE;
> +       if (network_ready &&
> +           !get_diskinfo(NETWORK_DRIVE, &geom)) {
> +               dev->drive = NETWORK_DRIVE;
> +               dev->part = 0;
> +               dev->length = geom.total_sectors;
> +               if (discerner(&dev, lookup)) {
> +                       count++;
> +                       if (lookup)
> +                               goto exit;
> +               }
> +       }
> +#endif /* SUPPORT_NETBOOT */
> + exit:
> +       return count;
> +}
>
> This won''t compile since network_ready is undeclared.
Yup, indeed..
>  Why is the btrfs code 
> dealing with network devices at all?
>   
Why not? :)
Well, would you please disable it for now with the attached patch?
 
Thanks,
Edward.

Am Dienstag 03 November 2009 01:59:39 schrieb Edward
Shishkin:
> Johannes Hirte wrote:
> >  Why is the btrfs code
> > dealing with network devices at all?
> 
> Why not? :)
I don''t see the possiblity to get a btrfs filesystem this way. So as
far as I
understand this, it''s complete useless. The CD support doesn''t
look very
usefull too to me. It''s possible to put a btrfs filesystem on a CD or
DVD. But
that seems rather theoretical.

regards,
  Johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Johannes Hirte wrote:
> Am Dienstag 03 November 2009 01:59:39 schrieb Edward Shishkin:
>   
>> Johannes Hirte wrote:
>>     
>>>  Why is the btrfs code
>>> dealing with network devices at all?
>>>       
>> Why not? :)
>>     
>
> I don''t see the possiblity to get a btrfs filesystem this way. So
as far as I
> understand this, it''s complete useless. The CD support
doesn''t look very
> usefull too to me. It''s possible to put a btrfs filesystem on a CD
or DVD. But
> that seems rather theoretical.
>   
Ok, let''s keep this theoretical possibility,
I don''t see wrong things here..

Thanks,
Edward.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html