Li Hong
2009-May-04 05:05 UTC
[PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize()
In Li Zefan''s commit dae7b665cf6d6e6e733f1c9c16cf55547dd37e33,
a combination call of kmalloc() and copy_from_user() is replaced by
memdup_user(). So btrfs_ioctl_resize() doesn''t use GFP_NOFS any more.
Signed-off-by: Li Hong <lihong.hi@gmail.com>
---
fs/btrfs/ioctl.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 5e94ea6..2624b53 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -437,10 +437,6 @@ out_unlock:
return 0;
}
-/*
- * Called inside transaction, so use GFP_NOFS
- */
-
static int btrfs_ioctl_resize(struct btrfs_root *root, void __user *arg)
{
u64 new_size;
--
1.6.2.1
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Chris Mason
2009-May-04 15:11 UTC
Re: [PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize()
On Mon, 2009-05-04 at 01:05 -0400, Li Hong wrote:> In Li Zefan''s commit dae7b665cf6d6e6e733f1c9c16cf55547dd37e33, > a combination call of kmalloc() and copy_from_user() is replaced by > memdup_user(). So btrfs_ioctl_resize() doesn''t use GFP_NOFS any more. > > Signed-off-by: Li Hong <lihong.hi@gmail.com> > --- > fs/btrfs/ioctl.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index 5e94ea6..2624b53 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -437,10 +437,6 @@ out_unlock: > return 0; > } > > -/* > - * Called inside transaction, so use GFP_NOFS > - */ > - > static int btrfs_ioctl_resize(struct btrfs_root *root, void __user *arg) > { > u64 new_size;Thanks, I''ve queued this one up. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html