Btrfs devel - Oct 2007 - two issues in btrfs-unstable

Hello Chris,

1.  In 'update_block_group',  when parameter 'alloc' is true,
free_space_cache isn't updated,  extent_map_radix is updated at the
same place in 0.8.  I feel it's like a typo.

2.  In btrfs_read_fs_root_no_radix,  root->root_key isn't setup. It
cause problem when drop dead root(I met a kernel Oops after mount a
unclean btrfs)

By the way,  please tell me whether you like this way to report bug
for btrfs-unstable.

Regards
YZ

On Wed, 2007-10-17 at 20:50 +0800, Yan Zheng wrote:
> Hello Chris,
> 
> 1.  In 'update_block_group',  when parameter 'alloc' is
true,
> free_space_cache isn't updated,  extent_map_radix is updated at the
> same place in 0.8.  I feel it's like a typo.
> 
This one was intentional, I update free_space_cache immediately after
finding the free extent.  This way the code to actually modify the
extenet tree doesn't try to use the same extent we just found.
> 2.  In btrfs_read_fs_root_no_radix,  root->root_key isn't setup. It
> cause problem when drop dead root(I met a kernel Oops after mount a
> unclean btrfs)
> 
Good catch, could you send a tested patch for that one please?
> By the way,  please tell me whether you like this way to report bug
> for btrfs-unstable.
Definitely, thank you!

-chris