Hi Jean-Christophe, Thanks for writing back-- I''m using the betternestedset mailing list now. Ah, I just looked at rubyforge and see that the code there has tests.> I''d like to build tests in the same was as > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > It''s probably a good model to follow.OK, let me know if I have this right: 1) If I want to contribute, I should work from the source code on rubyforge, not trac. 2) You are not happy with the current tests, and would instead like them to follow the model of acts_as_modified. Do you want me to start changing the tests, or is Tim Olsen still in charge of that? I don''t want to disrupt someone else''s work. Let me know how I can be helpful. Cheers, Krishna On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:> Hi Krishna, > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit : > > First of all, thanks for improving nested set and moving it to a > > plugin. > > Thks > > > Your ''better nested set'' looks promising, and I''d like to help with > > it. > > You''re welcome. > > > Before I start submitting patches, did you have a plan for how you > > want the tests set up? > > Tim Olsen began to help me too. He committed a bunch of things in the > rubyforge svn. I think it''s not appropriate. > I''d like to build tests in the same was as > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > It''s probably a good model to follow. > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while > other functions are on rubyforge, because I like trac ;-) > Do you know if we need a special setting in svn to be able to use > script/plugin install ? > > > PS: can we continue this discussion on the rubyforge betternestedset > mailling list ? > So it"ll be archived. > > Jean-Christophe Michel > -- > Sym?trie, ?dition de musique et services multim?dia > 30 rue Jean-Baptiste Say > 69001 LYON (FRANCE) > t?l +33 (0)478 29 52 14 > fax +33 (0)478 30 01 11 > web www.symetrie.com > >
Oops-- forgot to answer your svn install question:> Do you know if we need a special setting in svn to be able to use > script/plugin install ?It looks like everything is set up correctly for rubyforge, since the following two commands installed the plugin into a rails project for me: script/plugin source svn://rubyforge.org/var/svn/betternestedset script/plugin install betternestedset Is this what you were asking about? Or were you asking about Trac? k PS-- I don''t know if you''re having the same problem, but the betternestedset-talk mailing list seems to be taking forever to deliver emails to me. They show up in the list archives, but not in my in-box. On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:> Hi Jean-Christophe, > > Thanks for writing back-- I''m using the betternestedset mailing list now. > > Ah, I just looked at rubyforge and see that the code there has tests. > > > I''d like to build tests in the same was as > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > It''s probably a good model to follow. > > OK, let me know if I have this right: > 1) If I want to contribute, I should work from the source code on > rubyforge, not trac. > 2) You are not happy with the current tests, and would instead like > them to follow the model of acts_as_modified. > > Do you want me to start changing the tests, or is Tim Olsen still in > charge of that? I don''t want to disrupt someone else''s work. > > Let me know how I can be helpful. > > Cheers, > Krishna > > > On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > Hi Krishna, > > > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit : > > > First of all, thanks for improving nested set and moving it to a > > > plugin. > > > > Thks > > > > > Your ''better nested set'' looks promising, and I''d like to help with > > > it. > > > > You''re welcome. > > > > > Before I start submitting patches, did you have a plan for how you > > > want the tests set up? > > > > Tim Olsen began to help me too. He committed a bunch of things in the > > rubyforge svn. I think it''s not appropriate. > > I''d like to build tests in the same was as > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > It''s probably a good model to follow. > > > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while > > other functions are on rubyforge, because I like trac ;-) > > Do you know if we need a special setting in svn to be able to use > > script/plugin install ? > > > > > > PS: can we continue this discussion on the rubyforge betternestedset > > mailling list ? > > So it"ll be archived. > > > > Jean-Christophe Michel > > -- > > Sym?trie, ?dition de musique et services multim?dia > > 30 rue Jean-Baptiste Say > > 69001 LYON (FRANCE) > > t?l +33 (0)478 29 52 14 > > fax +33 (0)478 30 01 11 > > web www.symetrie.com > > > > >
oops. forgot to reply to all. -Tim On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote:> Feel free to scrap most of my work and start afresh. Jean-Christophe > convinced me I was going about it the wrong way. > > Cheers, > Tim > > On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote: > > Hi Jean-Christophe, > > > > Thanks for writing back-- I''m using the betternestedset mailing list now. > > > > Ah, I just looked at rubyforge and see that the code there has tests. > > > > > I''d like to build tests in the same was as > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > > It''s probably a good model to follow. > > > > OK, let me know if I have this right: > > 1) If I want to contribute, I should work from the source code on > > rubyforge, not trac. > > 2) You are not happy with the current tests, and would instead like > > them to follow the model of acts_as_modified. > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > charge of that? I don''t want to disrupt someone else''s work. > > > > Let me know how I can be helpful. > > > > Cheers, > > Krishna > > > > > > On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > > Hi Krishna, > > > > > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit : > > > > First of all, thanks for improving nested set and moving it to a > > > > plugin. > > > > > > Thks > > > > > > > Your ''better nested set'' looks promising, and I''d like to help with > > > > it. > > > > > > You''re welcome. > > > > > > > Before I start submitting patches, did you have a plan for how you > > > > want the tests set up? > > > > > > Tim Olsen began to help me too. He committed a bunch of things in the > > > rubyforge svn. I think it''s not appropriate. > > > I''d like to build tests in the same was as > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > > It''s probably a good model to follow. > > > > > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while > > > other functions are on rubyforge, because I like trac ;-) > > > Do you know if we need a special setting in svn to be able to use > > > script/plugin install ? > > > > > > > > > PS: can we continue this discussion on the rubyforge betternestedset > > > mailling list ? > > > So it"ll be archived. > > > > > > Jean-Christophe Michel > > > -- > > > Sym?trie, ?dition de musique et services multim?dia > > > 30 rue Jean-Baptiste Say > > > 69001 LYON (FRANCE) > > > t?l +33 (0)478 29 52 14 > > > fax +33 (0)478 30 01 11 > > > web www.symetrie.com > > > > > > > > _______________________________________________ > > Betternestedset-talk mailing list > > Betternestedset-talk at rubyforge.org > > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > >
Hi Krishna,> OK, let me know if I have this right: > 1) If I want to contribute, I should work from the source code on > rubyforge, not trac. > 2) You are not happy with the current tests, and would instead like > them to follow the model of acts_as_modified. > > Do you want me to start changing the tests, or is Tim Olsen still in > charge of that? I don''t want to disrupt someone else''s work.Good idea, since Tim agrees. Feel free to start from either code you prefer, the plugin code is the same, I think only tests and vendor/ are added into rubyforge. Add yourself to rubyforge, send your id and I''ll add it to the admin so you''ll be able to commit. Or if you''re not familiar with svn, send patches here and we''ll commit. Jean-Christophe Michel -- symetrie.com Better Nested Set for rails: http://opensource.symetrie.com/trac/better_nested_set
Hi, Le 7 nov. 06, ? 19:40, Krishna Dole a ?crit :> Oops-- forgot to answer your svn install question: >> Do you know if we need a special setting in svn to be able to use >> script/plugin install ? > > It looks like everything is set up correctly for rubyforge, since the > following two commands installed the plugin into a rails project for > me: > > script/plugin source svn://rubyforge.org/var/svn/betternestedset > script/plugin install betternestedset > > Is this what you were asking about?yes, good info. I''ll add it on trac home page.> PS-- I don''t know if you''re having the same problem, but the > betternestedset-talk mailing list seems to be taking forever to > deliver emails to me. They show up in the list archives, but not in my > in-box.True. Your mail arrived before my reply ;-) I changed to rubyforge to be able to deliver gems, not having to handle a mailling list... and spare some bandwidth if it becomes a success. But being able to work with the tools would be great ;p Jean-Christophe Michel -- symetrie.com Better Nested Set for rails: http://opensource.symetrie.com/trac/better_nested_set
Hi Tim, OK, tomorrow I''ll start trying to migrate the current tests to a new setup. k On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote:> oops. forgot to reply to all. > > -Tim > > On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote: > > Feel free to scrap most of my work and start afresh. Jean-Christophe > > convinced me I was going about it the wrong way. > > > > Cheers, > > Tim > > > > On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote: > > > Hi Jean-Christophe, > > > > > > Thanks for writing back-- I''m using the betternestedset mailing list now. > > > > > > Ah, I just looked at rubyforge and see that the code there has tests. > > > > > > > I''d like to build tests in the same was as > > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > > > It''s probably a good model to follow. > > > > > > OK, let me know if I have this right: > > > 1) If I want to contribute, I should work from the source code on > > > rubyforge, not trac. > > > 2) You are not happy with the current tests, and would instead like > > > them to follow the model of acts_as_modified. > > > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > > charge of that? I don''t want to disrupt someone else''s work. > > > > > > Let me know how I can be helpful. > > > > > > Cheers, > > > Krishna > > > > > > > > > On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > > > Hi Krishna, > > > > > > > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit : > > > > > First of all, thanks for improving nested set and moving it to a > > > > > plugin. > > > > > > > > Thks > > > > > > > > > Your ''better nested set'' looks promising, and I''d like to help with > > > > > it. > > > > > > > > You''re welcome. > > > > > > > > > Before I start submitting patches, did you have a plan for how you > > > > > want the tests set up? > > > > > > > > Tim Olsen began to help me too. He committed a bunch of things in the > > > > rubyforge svn. I think it''s not appropriate. > > > > I''d like to build tests in the same was as > > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified > > > > It''s probably a good model to follow. > > > > > > > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while > > > > other functions are on rubyforge, because I like trac ;-) > > > > Do you know if we need a special setting in svn to be able to use > > > > script/plugin install ? > > > > > > > > > > > > PS: can we continue this discussion on the rubyforge betternestedset > > > > mailling list ? > > > > So it"ll be archived. > > > > > > > > Jean-Christophe Michel > > > > -- > > > > Sym?trie, ?dition de musique et services multim?dia > > > > 30 rue Jean-Baptiste Say > > > > 69001 LYON (FRANCE) > > > > t?l +33 (0)478 29 52 14 > > > > fax +33 (0)478 30 01 11 > > > > web www.symetrie.com > > > > > > > > > > > _______________________________________________ > > > Betternestedset-talk mailing list > > > Betternestedset-talk at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > > > > >
oops, forgot to send to the list... On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:> Hi Jean-Christophe, > > Great, thanks for being willing to add me as a developer. My rubyforge > user ID is 12328 and my login name is kpd. I''m familiar with svn, so > that should work fine. > > Messages to the list are still taking a while to get to me, so I > apologize for delayed email tag. > > k > > On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > Hi Krishna, > > > > > > > OK, let me know if I have this right: > > > 1) If I want to contribute, I should work from the source code on > > > rubyforge, not trac. > > > 2) You are not happy with the current tests, and would instead like > > > them to follow the model of acts_as_modified. > > > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > > charge of that? I don''t want to disrupt someone else''s work. > > > > Good idea, since Tim agrees. > > Feel free to start from either code you prefer, the plugin code is the > > same, I think only tests and vendor/ are added into rubyforge. > > Add yourself to rubyforge, send your id and I''ll add it to the admin > > so you''ll be able to commit. > > Or if you''re not familiar with svn, send patches here and we''ll commit. > > > > Jean-Christophe Michel > > -- > > symetrie.com > > > > Better Nested Set for rails: > > http://opensource.symetrie.com/trac/better_nested_set > > > > _______________________________________________ > > Betternestedset-talk mailing list > > Betternestedset-talk at rubyforge.org > > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > >
Hi Jean-Christophe, I''ve implemented the new test setup, but it looks like better_nested_set isn''t overriding the built-in nested set in rails core. In other words the tests are all passing, but they aren''t using our nested set code. Any ideas? k On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:> Hi Krishna, > > > > OK, let me know if I have this right: > > 1) If I want to contribute, I should work from the source code on > > rubyforge, not trac. > > 2) You are not happy with the current tests, and would instead like > > them to follow the model of acts_as_modified. > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > charge of that? I don''t want to disrupt someone else''s work. > > Good idea, since Tim agrees. > Feel free to start from either code you prefer, the plugin code is the > same, I think only tests and vendor/ are added into rubyforge. > Add yourself to rubyforge, send your id and I''ll add it to the admin > so you''ll be able to commit. > Or if you''re not familiar with svn, send patches here and we''ll commit. > > Jean-Christophe Michel > -- > symetrie.com > > Better Nested Set for rails: > http://opensource.symetrie.com/trac/better_nested_set > > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk >
hang on... my mistake. i needed to mix the module into active record in my abstract_unit.rb, since init.rb wasn''t getting loaded in testing. k On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:> Hi Jean-Christophe, > > I''ve implemented the new test setup, but it looks like > better_nested_set isn''t overriding the built-in nested set in rails > core. In other words the tests are all passing, but they aren''t using > our nested set code. > > Any ideas? > > k > > On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > Hi Krishna, > > > > > > > OK, let me know if I have this right: > > > 1) If I want to contribute, I should work from the source code on > > > rubyforge, not trac. > > > 2) You are not happy with the current tests, and would instead like > > > them to follow the model of acts_as_modified. > > > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > > charge of that? I don''t want to disrupt someone else''s work. > > > > Good idea, since Tim agrees. > > Feel free to start from either code you prefer, the plugin code is the > > same, I think only tests and vendor/ are added into rubyforge. > > Add yourself to rubyforge, send your id and I''ll add it to the admin > > so you''ll be able to commit. > > Or if you''re not familiar with svn, send patches here and we''ll commit. > > > > Jean-Christophe Michel > > -- > > symetrie.com > > > > Better Nested Set for rails: > > http://opensource.symetrie.com/trac/better_nested_set > > > > _______________________________________________ > > Betternestedset-talk mailing list > > Betternestedset-talk at rubyforge.org > > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > >
Hi Tim and Jean-Christophe, The new test setup appears to be working, but there are two things in better_nested_set that break some of the tests. Let me know when I have access to the repository-- I want to commit these changes and get feedback from you guys before mucking around with other things. k On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:> hang on... my mistake. i needed to mix the module into active record > in my abstract_unit.rb, since init.rb wasn''t getting loaded in > testing. > > k > > On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote: > > Hi Jean-Christophe, > > > > I''ve implemented the new test setup, but it looks like > > better_nested_set isn''t overriding the built-in nested set in rails > > core. In other words the tests are all passing, but they aren''t using > > our nested set code. > > > > Any ideas? > > > > k > > > > On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote: > > > Hi Krishna, > > > > > > > > > > OK, let me know if I have this right: > > > > 1) If I want to contribute, I should work from the source code on > > > > rubyforge, not trac. > > > > 2) You are not happy with the current tests, and would instead like > > > > them to follow the model of acts_as_modified. > > > > > > > > Do you want me to start changing the tests, or is Tim Olsen still in > > > > charge of that? I don''t want to disrupt someone else''s work. > > > > > > Good idea, since Tim agrees. > > > Feel free to start from either code you prefer, the plugin code is the > > > same, I think only tests and vendor/ are added into rubyforge. > > > Add yourself to rubyforge, send your id and I''ll add it to the admin > > > so you''ll be able to commit. > > > Or if you''re not familiar with svn, send patches here and we''ll commit. > > > > > > Jean-Christophe Michel > > > -- > > > symetrie.com > > > > > > Better Nested Set for rails: > > > http://opensource.symetrie.com/trac/better_nested_set > > > > > > _______________________________________________ > > > Betternestedset-talk mailing list > > > Betternestedset-talk at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > > > > >