George Joseph
2022-Aug-03 19:51 UTC
[asterisk-users] [External] [External] Geo location 18.14.0-rc1 question
Looks like it'll be tomorrow before I can get the patch up. I ran into some strange issues. On Tue, Aug 2, 2022 at 1:43 PM Dan Cropp <dan at amtelco.com> wrote:> Thank you George > > > > *From:* asterisk-users <asterisk-users-bounces at lists.digium.com> *On > Behalf Of *George Joseph > *Sent:* Tuesday, August 2, 2022 2:40 PM > *To:* Asterisk Users Mailing List - Non-Commercial Discussion < > asterisk-users at lists.digium.com> > *Subject:* Re: [External] [asterisk-users] [External] Geo location > 18.14.0-rc1 question > > > > > > > > On Tue, Aug 2, 2022 at 1:35 PM George Joseph <gjoseph at sangoma.com> wrote: > > > > > > On Tue, Aug 2, 2022 at 1:13 PM Dan Cropp <dan at amtelco.com> wrote: > > Is the allow_routing setting on the geolocation Wiki Profile also not > fully implemented? > > > > Well, 99% of the code is there. The 1% is parsing the config option. Not > sure how I missed that. > > I'll have a patch up first thing in the morning UTC-6. > > I'll call it "allow_use_for_routing" in profile. > > > > Actually just "allow_routing_use" > > > > > > > > In the code, I see geolocation_routing used instead of allow_routing. > > > > Tried both and Asterisk indicates it cannot find suitable setting so it > doesn’t create the profile object. > > > > Dan > > > > *From:* Dan Cropp > *Sent:* Tuesday, August 2, 2022 10:04 AM > *To:* Asterisk Users Mailing List - Non-Commercial Discussion < > asterisk-users at lists.digium.com> > *Subject:* RE: [External] [asterisk-users] Geo location 18.14.0-rc1 > question > > > > Thank you George. > > > > *From:* asterisk-users <asterisk-users-bounces at lists.digium.com> *On > Behalf Of *George Joseph > *Sent:* Tuesday, August 2, 2022 9:57 AM > *To:* Asterisk Users Mailing List - Non-Commercial Discussion < > asterisk-users at lists.digium.com> > *Subject:* Re: [External] [asterisk-users] Geo location 18.14.0-rc1 > question > > > > > > > > On Tue, Aug 2, 2022 at 8:46 AM Dan Cropp <dan at amtelco.com> wrote: > > I believe I have everything configured correctly, but Asterisk is > complaining about my configuration > > > > It is complaining about confidence settings. > > > > From the Asterisk Geolocation Implementation Wiki, I believe I have this > set correctly. > > > > Sub-parameters: > > - value: A percentage indicating the confidence or "unknown". > - pdf: "unknown", "normal" or "rectangular" > Example: confidence = value=80, pdf=unknown > If no confidence parameter is specified, the default is 95%. > See RFC7459 > <https://wiki.asterisk.org/wiki/display/AST/Geolocation+Reference+Information#GeolocationReferenceInformation-rfc7459> for > the exact definition of this parameter. > > > > > > [08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find option > suitable for category 'IS_loc_1' named 'confidence' at line 12 of > > [08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create > an object of type 'location' with id 'IS_loc_1' from configuration file > 'geolocation.conf' > > > > [IS_loc_1] > > type = location > > format = civicAddress > > confidence = value=95, pdf=unknown > > location_info = country=US,A1=Wisconsin,A3=Madison > > location_info = HNO=4800,RD=Main,STS=Drive,PC=53704 > > > > Remove the confidence param for now. I documented it before I > implemented it. :) > > > > > > > > Also seeing problems with location_refinement setting. > > Again, I believe my setting matches what is on the Asterisk Geolocation > Implementation wiki. > > > > [08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find option > suitable for category 'IS_prof_20' named 'location_refinement' at line 56 of > > [08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create > an object of type 'profile' with id 'IS_prof_20' from configuration file > 'geolocation.conf' > > > > [IS_prof_20] > > type = profile > > profile_action = prefer_incoming > > pidf_element = person > > usage_rules = retransmission_allowed=no > > location_reference = IS_loc_22 > > location_refinement = ROOM=292 > > location_refinement = FLR=1 > > > > Pffft. I renamed this to "location_info_refinement" to better match the > "location_info" parameter in the Location object. I forgot to rename it in > the wiki documentation. If you just change the name it should work. > > > > > > > > > > > > Dan > > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > Check out the new Asterisk community forum at: > https://community.asterisk.org/ > > New to Asterisk? Start here: > https://wiki.asterisk.org/wiki/display/AST/Getting+Started > > asterisk-users mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > Check out the new Asterisk community forum at: > https://community.asterisk.org/ > > New to Asterisk? Start here: > https://wiki.asterisk.org/wiki/display/AST/Getting+Started > > asterisk-users mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > Check out the new Asterisk community forum at: > https://community.asterisk.org/ > > New to Asterisk? Start here: > https://wiki.asterisk.org/wiki/display/AST/Getting+Started > > asterisk-users mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.digium.com/pipermail/asterisk-users/attachments/20220803/003f73d9/attachment.html>
George Joseph
2022-Aug-10 13:57 UTC
[asterisk-users] [External] [External] Geo location 18.14.0-rc1 question
Sorry for the delay but this turned out to be a bit more complex than I anticipated. There are reviews up on Gerrit for the 16 and 18 branches that address the issues below as well as clean up the implementation, plug some memory leaks, etc. 16: https://gerrit.asterisk.org/c/asterisk/+/18896 18: https://gerrit.asterisk.org/c/asterisk/+/18897 I anticipate these will make it into the next set of release candidates which are due to be cut tomorrow. Give them a try. On Wed, Aug 3, 2022 at 1:51 PM George Joseph <gjoseph at sangoma.com> wrote:> Looks like it'll be tomorrow before I can get the patch up. I ran into > some strange issues. > > On Tue, Aug 2, 2022 at 1:43 PM Dan Cropp <dan at amtelco.com> wrote: > >> Thank you George >> >> >> >> *From:* asterisk-users <asterisk-users-bounces at lists.digium.com> *On >> Behalf Of *George Joseph >> *Sent:* Tuesday, August 2, 2022 2:40 PM >> *To:* Asterisk Users Mailing List - Non-Commercial Discussion < >> asterisk-users at lists.digium.com> >> *Subject:* Re: [External] [asterisk-users] [External] Geo location >> 18.14.0-rc1 question >> >> >> >> >> >> >> >> On Tue, Aug 2, 2022 at 1:35 PM George Joseph <gjoseph at sangoma.com> wrote: >> >> >> >> >> >> On Tue, Aug 2, 2022 at 1:13 PM Dan Cropp <dan at amtelco.com> wrote: >> >> Is the allow_routing setting on the geolocation Wiki Profile also not >> fully implemented? >> >> >> >> Well, 99% of the code is there. The 1% is parsing the config option. >> Not sure how I missed that. >> >> I'll have a patch up first thing in the morning UTC-6. >> >> I'll call it "allow_use_for_routing" in profile. >> >> >> >> Actually just "allow_routing_use" >> >> >> >> >> >> >> >> In the code, I see geolocation_routing used instead of allow_routing. >> >> >> >> Tried both and Asterisk indicates it cannot find suitable setting so it >> doesn’t create the profile object. >> >> >> >> Dan >> >> >> >> *From:* Dan Cropp >> *Sent:* Tuesday, August 2, 2022 10:04 AM >> *To:* Asterisk Users Mailing List - Non-Commercial Discussion < >> asterisk-users at lists.digium.com> >> *Subject:* RE: [External] [asterisk-users] Geo location 18.14.0-rc1 >> question >> >> >> >> Thank you George. >> >> >> >> *From:* asterisk-users <asterisk-users-bounces at lists.digium.com> *On >> Behalf Of *George Joseph >> *Sent:* Tuesday, August 2, 2022 9:57 AM >> *To:* Asterisk Users Mailing List - Non-Commercial Discussion < >> asterisk-users at lists.digium.com> >> *Subject:* Re: [External] [asterisk-users] Geo location 18.14.0-rc1 >> question >> >> >> >> >> >> >> >> On Tue, Aug 2, 2022 at 8:46 AM Dan Cropp <dan at amtelco.com> wrote: >> >> I believe I have everything configured correctly, but Asterisk is >> complaining about my configuration >> >> >> >> It is complaining about confidence settings. >> >> >> >> From the Asterisk Geolocation Implementation Wiki, I believe I have this >> set correctly. >> >> >> >> Sub-parameters: >> >> - value: A percentage indicating the confidence or "unknown". >> - pdf: "unknown", "normal" or "rectangular" >> Example: confidence = value=80, pdf=unknown >> If no confidence parameter is specified, the default is 95%. >> See RFC7459 >> <https://wiki.asterisk.org/wiki/display/AST/Geolocation+Reference+Information#GeolocationReferenceInformation-rfc7459> for >> the exact definition of this parameter. >> >> >> >> >> >> [08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find >> option suitable for category 'IS_loc_1' named 'confidence' at line 12 of >> >> [08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create >> an object of type 'location' with id 'IS_loc_1' from configuration file >> 'geolocation.conf' >> >> >> >> [IS_loc_1] >> >> type = location >> >> format = civicAddress >> >> confidence = value=95, pdf=unknown >> >> location_info = country=US,A1=Wisconsin,A3=Madison >> >> location_info = HNO=4800,RD=Main,STS=Drive,PC=53704 >> >> >> >> Remove the confidence param for now. I documented it before I >> implemented it. :) >> >> >> >> >> >> >> >> Also seeing problems with location_refinement setting. >> >> Again, I believe my setting matches what is on the Asterisk Geolocation >> Implementation wiki. >> >> >> >> [08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find >> option suitable for category 'IS_prof_20' named 'location_refinement' at >> line 56 of >> >> [08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create >> an object of type 'profile' with id 'IS_prof_20' from configuration file >> 'geolocation.conf' >> >> >> >> [IS_prof_20] >> >> type = profile >> >> profile_action = prefer_incoming >> >> pidf_element = person >> >> usage_rules = retransmission_allowed=no >> >> location_reference = IS_loc_22 >> >> location_refinement = ROOM=292 >> >> location_refinement = FLR=1 >> >> >> >> Pffft. I renamed this to "location_info_refinement" to better match the >> "location_info" parameter in the Location object. I forgot to rename it in >> the wiki documentation. If you just change the name it should work. >> >> >> >> >> >> >> >> >> >> >> >> Dan >> >> -- >> _____________________________________________________________________ >> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >> >> Check out the new Asterisk community forum at: >> https://community.asterisk.org/ >> >> New to Asterisk? Start here: >> https://wiki.asterisk.org/wiki/display/AST/Getting+Started >> >> asterisk-users mailing list >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users >> >> -- >> _____________________________________________________________________ >> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >> >> Check out the new Asterisk community forum at: >> https://community.asterisk.org/ >> >> New to Asterisk? Start here: >> https://wiki.asterisk.org/wiki/display/AST/Getting+Started >> >> asterisk-users mailing list >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users >> >> -- >> _____________________________________________________________________ >> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >> >> Check out the new Asterisk community forum at: >> https://community.asterisk.org/ >> >> New to Asterisk? Start here: >> https://wiki.asterisk.org/wiki/display/AST/Getting+Started >> >> asterisk-users mailing list >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.digium.com/pipermail/asterisk-users/attachments/20220810/8ba7ed48/attachment.html>