Is this patch correct? The "&&" doesn't make logical sense to me. I think it should be "||" and making this change fixes the problem I have with SIP phones in MeetMe conferences. If it's correct, is there someplace more formal that I should submit it to? *** app_meetme.c.old 2009-10-11 17:56:44.000000000 -0400 --- app_meetme.c 2009-10-17 14:22:29.000000000 -0400 *************** *** 2901,2905 **** to write out all the samples. */ ! if (user->talking && !(confflags & CONFFLAG_OPTIMIZETALKER)) { careful_write(fd, f->data.ptr, f->datalen, 0); } --- 2901,2905 ---- to write out all the samples. */ ! if (user->talking || !(confflags & CONFFLAG_OPTIMIZETALKER)) { careful_write(fd, f->data.ptr, f->datalen, 0); }
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner <kenner at gnat.com> wrote:> Is this patch correct? The "&&" doesn't make logical sense to me. I think > it should be "||" and making this change fixes the problem I have with SIP > phones in MeetMe conferences. If it's correct, is there someplace more > formal that I should submit it to?I don't know if it's correct since I don't know what the CONFFLAG_OPTIMIZETALKER flag does nor what your problem is. Giving more background info should help. If you want to submit a patch use issues.asterisk.org and read the guidelines before submitting the bug report. -- Moises Silva Software Developer Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3 Canada t. 1 905 474 1990 x 128 | e. moy at sangoma.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.digium.com/pipermail/asterisk-users/attachments/20091017/110b1f47/attachment.htm
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner <kenner at gnat.com> wrote:> Is this patch correct? ?The "&&" doesn't make logical sense to me. ?I think > it should be "||" and making this change fixes the problem I have with SIP > phones in MeetMe conferences. ?If it's correct, is there someplace more > formal that I should submit it to? > > *** app_meetme.c.old ? ?2009-10-11 17:56:44.000000000 -0400 > --- app_meetme.c ? ? ? ?2009-10-17 14:22:29.000000000 -0400 > *************** > *** 2901,2905 **** > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? to write out all the samples. > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? */ > ! ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (user->talking && !(confflags & CONFFLAG_OPTIMIZETALKER)) { > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?careful_write(fd, f->data.ptr, f->datalen, 0); > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?} > --- 2901,2905 ---- > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? to write out all the samples. > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? */ > ! ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (user->talking || !(confflags & CONFFLAG_OPTIMIZETALKER)) { > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?careful_write(fd, f->data.ptr, f->datalen, 0); > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?}I have a limited acquaintance with the app_meetme.c code, having also modified it for my own purposes in the past. For some historical perspective, you should know that originally in 1.6, talker optimization was forced on, with no way to turn it off. Many people reported that it sounded awful, and patches were released to make optimization be off by default, with a flag to turn it on, the way it was in 1.4 There are more details, especially as regards versions were various patches from trunk were merged into the releases, but that's the very quick version. If you want bug numbers, please check out http://issues.asterisk.org and search for talker optimization and meetme. When I first tried to use MeetMe with 1.6, I had a lot of voice-cut-out problems, which I was able to verify were caused by over-aggressive talker optimization, resulting in me going to 1.6.1.* series as that series at that time had the 'optimization off by default' feature that I wanted.
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner <kenner at gnat.com> wrote:> Is this patch correct? ?The "&&" doesn't make logical sense to me. ?I think > it should be "||" and making this change fixes the problem I have with SIP > phones in MeetMe conferences. ?If it's correct, is there someplace more > formal that I should submit it to?So now I actually read through your patch. Please read my last post about getting up to speed with how the history of talker optimization with MeetMe() in 1.6 has gone. Having said that, I think you may be using talker optimization and that this was causing the same voice cut out problem I was having. What version are you running? Does that version support disabling talker optimization? Have you tried disabling talker optimization? I appreciate your work on this, but I fear your issues may have already been solved a rather long time ago.