asterisk users - Jul 2007 - Music on hold problem

Hi,
I am using asterisk 1.4.
I have confgured the musiconhold.conf file.
However, when i make a call and then hold the call it does nothing.
in the CLI i do not see the starting/stopping musiconhold messages.

i am making calls from sip to h323 using asterisk assip/h323 gateway
(with gnugk and ooh323).
i get the following messages when putting the call on hold:

-- Executing [204 at default:1] Ringing("OOH323/1169fed2-70c5",
"") in new stack
    -- Executing [204 at default:2] Dial("OOH323/1169fed2-70c5",
"SIP/ht04|6|r") in new stack
    -- Called ht04
    -- SIP/ht04-081fe7f0 is ringing
    -- SIP/ht04-081fe7f0 answered OOH323/1169fed2-70c5
<...on hold...>
[Jul 17 11:19:22] WARNING[23645]: src/chan_h323.c:1044
ooh323_indicate: Don't know how to indicate condition -1 on ooh323c_1
[Jul 17 11:19:25] NOTICE[23645]: rtp.c:783 process_rfc3389: Comfort
noise support incomplete in Asterisk (RFC 3389). Please turn off on
client if possible. Client IP: 10.4.0.116
[Jul 17 11:19:25] WARNING[23645]: src/chan_h323.c:1044
ooh323_indicate: Don't know how to indicate condition 16 on ooh323c_1

I have no idea why the musiconhold is not triggered,  what those
messages mean (dont know how to indicate condition) and if they are
related to the music on hold problem


someone has any idea?

in the CLI i type
CLI> moh show files
and i see one file i put in the directory.

i tried configuring the musiconhold.conf file as quitemp3, files and
also custom (installing mpg123) but none of them starts musiconhold.

do i need to activate musiconhold somewhere else?

any help is welcome
thanks

yonoko molomo wrote:
> [Jul 17 11:19:22] WARNING[23645]: src/chan_h323.c:1044
> ooh323_indicate: Don't know how to indicate condition -1 on ooh323c_1
> [Jul 17 11:19:25] NOTICE[23645]: rtp.c:783 process_rfc3389: Comfort
> noise support incomplete in Asterisk (RFC 3389). Please turn off on
> client if possible. Client IP: 10.4.0.116
> [Jul 17 11:19:25] WARNING[23645]: src/chan_h323.c:1044
> ooh323_indicate: Don't know how to indicate condition 16 on ooh323c_1
This would be a bug in the ooh323 channel driver.  Feel free to report it to 
bugs.digium.com.  I think it's an easy fix.

...

In fact, here is a patch that should fix it.  Feel free to go ahead and give it 
a try and let me know if it fixes the problem for you.  However, please still 
report it to bugs.digium.com, or I will forget to merge the change.


Index: asterisk-ooh323c/src/chan_h323.c
==================================================================---
asterisk-ooh323c/src/chan_h323.c    (revision 413)
+++ asterisk-ooh323c/src/chan_h323.c    (working copy)
@@ -1036,9 +1036,16 @@
              ast_set_flag(p, H323_ALREADYGONE);
           }
           break;
+      case AST_CONTROL_HOLD:
+         ast_moh_start(ast, data, NULL);
+         break;
+      case AST_CONTROL_UNHOLD:
+            ast_moh_stop(ast);
+         break;
        case AST_CONTROL_PROCEEDING:
        case AST_CONTROL_RINGING:
        case AST_CONTROL_PROGRESS:
+      case -1;
           break;
        default:
           ast_log(LOG_WARNING,"Don't know how to indicate condition %d
on %s\n",


-- 
Russell Bryant
Software Engineer
Digium, Inc.