asterisk users - Oct 2004 - Re: [Asterisk-Dev] How to submit a patch?

Just so everyone's clear on the patch submission etiquette here...
(sorry for the crosspost, but I believe this is relevant to both 
users/dev lists)

To submit a patch, PLEASE PLEASE PLEASE help us out by doing the following:

Search the bugtracker to see if someone has already submitted a 
patch/request/bug that may be relevant to your patch.  If so, please use 
the existing bug, and follow the relevant sections below.  If not, 
please follow the following guidelines:

1)  make sure you save your patch in a unified diff, based on 
stable/head cvs if possible.  (cvs diff -u path/to/file.c [within the 
asterisk source tree will keep you from having to have two copies of the 
source file, too]) and save it into a file ending in a .txt extension 
(for faster review by us bug marshals, and Mark.

2) make sure you add the header "[patch]" without quotes to the 
subject/summary field.  This will help us quickly identify your bug as a 
patch, and will once again, help speed up the process.

3) please refrain from using whitespaces instead of tabs within your 
patch, also, please try not to add any unnecessary whitespace. 

and last but not least

4) if you don't already have a disclaimer on file, please file one.  
Once filed, PLEASE mention somewhere in your bug that you have one on 
file.  This saves a lot of time, and has held back lots of good patches, 
because the powers that be have to ask, then wait on a response as to 
wether or not the patch has been properly disclaimed.

Thanks for listening!

Kevin Walsh wrote:
>>I've found some problems in the implementation of say_number for
>>portuguese and I have some corrections that I would like to submit to be
>>incorporated to the CVS. 
>>
>>How do I do that? Is there any place where this process is already
>>written? Or can someone explain to me?
>>
>>My feeling is that I should first open a bug at Mantis describing the
>>problem I found and attaching my patch. Then what?
>>
>>    
>>
>That's all.  As you said, you just need to open a bug report and attach
>your patch.  The report and patch will be evaluated at some point and
>might make it into CVS if it corrects an identifiable problem or provides
>a new/enhanced feature.
>
>  
>

Josh, please help me as I'm really naive to this process. Is there a
specific text you would like to see in the disclaimer? Where should I
send this disclaimer file to?

Tks,

Renato


On Mon, 25 Oct 2004 21:08:35 -0500, Josh Roberson
<twisted@indigent-networks.com> wrote:
> Just so everyone's clear on the patch submission etiquette here...
> (sorry for the crosspost, but I believe this is relevant to both
> users/dev lists)
> 
> To submit a patch, PLEASE PLEASE PLEASE help us out by doing the following:
> 
> Search the bugtracker to see if someone has already submitted a
> patch/request/bug that may be relevant to your patch.  If so, please use
> the existing bug, and follow the relevant sections below.  If not,
> please follow the following guidelines:
> 
> 1)  make sure you save your patch in a unified diff, based on
> stable/head cvs if possible.  (cvs diff -u path/to/file.c [within the
> asterisk source tree will keep you from having to have two copies of the
> source file, too]) and save it into a file ending in a .txt extension
> (for faster review by us bug marshals, and Mark.
> 
> 2) make sure you add the header "[patch]" without quotes to the
> subject/summary field.  This will help us quickly identify your bug as a
> patch, and will once again, help speed up the process.
> 
> 3) please refrain from using whitespaces instead of tabs within your
> patch, also, please try not to add any unnecessary whitespace.
> 
> and last but not least
> 
> 4) if you don't already have a disclaimer on file, please file one.
> Once filed, PLEASE mention somewhere in your bug that you have one on
> file.  This saves a lot of time, and has held back lots of good patches,
> because the powers that be have to ask, then wait on a response as to
> wether or not the patch has been properly disclaimed.
> 
> Thanks for listening!
>