Has there been any resolution to this? Does anyone have a good way to allow someone to choose whether they want to be able to transfer a call vs send the # to the other end. Is there a simple way to change the Transfer key for # to *? John
There is a better way to deal with this, it's the doublehash patch. This patch makes it so you have to press the hash key twice to transfer a call instead of once as is default in Asterisk. Sad thing is that every time the parking code changes the patch has to change(sometimes twice a week) and I don't have a patch for the most recent CVS. I've asked numerous times for some wonderful Asterisk-code-God(please Mark ;)) to make it a configurable variable in the parking.conf file but noone seems to think it's worthy of doing. It's actually a rather simple code change from what I can guess reading the patch code. I've been told that the core developers(Mark) don't want to mess with doublehash, but maybe if enough people say they want it we can get them to make this harmless addition to the parking code. Here's a bug where it's been talked about: http://bugs.digium.com/bug_view_page.php?bug_id=0000885 MATT--- -----Original Message----- From: John Congdon [mailto:john@z1g.com] Sent: Tuesday, March 09, 2004 4:24 PM To: Asterisk Mailling List Subject: [Asterisk-Users] Outbound Transfer and the # key Has there been any resolution to this? Does anyone have a good way to allow someone to choose whether they want to be able to transfer a call vs send the # to the other end. Is there a simple way to change the Transfer key for # to *? John _______________________________________________ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Anything would be an improvement over how we have to patch constantly to use transfers now. As for not having to send # more than transfer, not quite true in my case. One of the companies that is is our building uses our system in a semi-automated fashion to contact banks to verify funds available for creation of customer accounts. They very often need to press # to navigate financial IVR systems and often have to transfer their calls internally. MATT--- -----Original Message----- From: Adam Goryachev [mailto:mailinglists@websitemanagers.com.au] Sent: Tuesday, March 09, 2004 9:45 PM To: asterisk-users@lists.digium.com Subject: RE: [Asterisk-Users] Outbound Transfer and the # key I can't add a comment to the bug tracker without logging in, and I forget my login details.... anyway, I would suggest changing the patch to the opposite behaviour. ie, single # is transfer, but double # means send a # to the remote. This would mean that in the majority of cases, things don't change for the end user, which might make it more likely for the patch to be accepted?? Also, I think you are going to transfer a call more frequantly than you will need to send # ... Regards, Adam On Wed, 2004-03-10 at 08:53, mattf wrote:> There is a better way to deal with this, it's the doublehash patch. This > patch makes it so you have to press the hash key twice to transfer a call > instead of once as is default in Asterisk. > > Sad thing is that every time the parking code changes the patch has to > change(sometimes twice a week) and I don't have a patch for the mostrecent> CVS. I've asked numerous times for some wonderful Asterisk-code-God(please > Mark ;)) to make it a configurable variable in the parking.conf file but > noone seems to think it's worthy of doing. It's actually a rather simple > code change from what I can guess reading the patch code. I've been told > that the core developers(Mark) don't want to mess with doublehash, butmaybe> if enough people say they want it we can get them to make this harmless > addition to the parking code. > > Here's a bug where it's been talked about: > http://bugs.digium.com/bug_view_page.php?bug_id=0000885 > > MATT--- > > > -----Original Message----- > From: John Congdon [mailto:john@z1g.com] > Sent: Tuesday, March 09, 2004 4:24 PM > To: Asterisk Mailling List > Subject: [Asterisk-Users] Outbound Transfer and the # key > > > Has there been any resolution to this? > > Does anyone have a good way to allow > someone to choose whether they want to > be able to transfer a call vs send the # to > the other end. > > Is there a simple way to change the Transfer > key for # to *? > > > John > > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users-- -- Adam Goryachev Website Managers Ph: +61 2 9345 4395 adam@websitemanagers.com.au Fax: +61 2 9345 4396 www.websitemanagers.com.au _______________________________________________ Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Here's my patch results: [root@machine asterisk]# patch -p0 < ./Parking.patch patching file res/res_parking.c Hunk #1 FAILED at 25. Hunk #2 succeeded at 228 (offset 13 lines). Hunk #3 succeeded at 288 (offset 12 lines). Hunk #4 succeeded at 408 (offset 13 lines). 1 out of 4 hunks FAILED -- saving rejects to file res/res_parking.c.rej [root@VICIast1 asterisk]# cat res/res_parking.c.rej *************** *** 25,30 **** #include <asterisk/musiconhold.h> #include <asterisk/config.h> #include <asterisk/cli.h> #include <stdlib.h> #include <errno.h> #include <unistd.h> --- 25,31 ---- #include <asterisk/musiconhold.h> #include <asterisk/config.h> #include <asterisk/cli.h> + #include <asterisk/indications.h> #include <stdlib.h> #include <errno.h> #include <unistd.h> is the first fail a bad thing? This is CVS from 15 minutes ago. Thanks, MATT--- -----Original Message----- From: Iain Stevenson [mailto:iain@iainstevenson.com] Sent: Wednesday, March 10, 2004 4:33 PM To: asterisk-users@lists.digium.com Subject: Re: [Asterisk-Users] Outbound Transfer and the # key Try the attached patch. Go to your asterisk root directory and type: patch -p0 < path_to_patch/Parking.patch .. then rebuild asterisk. Iain --On Wednesday, March 10, 2004 7:43 am -0500 John Congdon <john@z1g.com> wrote:> I have applied the patch and restarted Asterisk. > > But it still only requires a single # to transfer. > Did I possibly miss something? > > This is just to show that it was applied. > > [root@pbx asterisk]# pwd > /usr/src/asterisk > [root@pbx asterisk]# patch -p0 < ../old_asterisk/doublehash.patch > patching file res/res_parking.c > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 3 out of 3 hunks ignored -- saving rejects to file res/res_parking.c.rej > > > John > > > > On Mar 9, 2004, at 4:53 PM, mattf wrote: > > There is a better way to deal with this, it's the doublehash patch. This > patch makes it so you have to press the hash key twice to transfer a call > instead of once as is default in Asterisk. > > Sad thing is that every time the parking code changes the patch has to > change(sometimes twice a week) and I don't have a patch for the most > recent CVS. I've asked numerous times for some wonderful > Asterisk-code-God(please Mark ;)) to make it a configurable variable in > the parking.conf file but noone seems to think it's worthy of doing. It's > actually a rather simple code change from what I can guess reading the > patch code. I've been told that the core developers(Mark) don't want to > mess with doublehash, but maybe if enough people say they want it we can > get them to make this harmless addition to the parking code. > > Here's a bug where it's been talked about: > http://bugs.digium.com/bug_view_page.php?bug_id=0000885 > > MATT--- > > > -----Original Message----- > From: John Congdon [mailto:john@z1g.com] > Sent: Tuesday, March 09, 2004 4:24 PM > To: Asterisk Mailling List > Subject: [Asterisk-Users] Outbound Transfer and the # key > > > Has there been any resolution to this? > > Does anyone have a good way to allow > someone to choose whether they want to > be able to transfer a call vs send the # to > the other end. > > Is there a simple way to change the Transfer > key for # to *? > > > John > > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users >
works great, thanks for posting it. This illustrates my point perfectly that to have this functionality you have to modify the patch every time you want to upgrade your CVS. Is there any way we can pursuade Mark to at least make it a compile-time option if not a parking.conf option? Thanks, MATT--- -----Original Message----- From: Iain Stevenson [mailto:iain@iainstevenson.com] Sent: Thursday, March 11, 2004 2:31 AM To: asterisk-users@lists.digium.com Subject: RE: [Asterisk-Users] Outbound Transfer and the # key Oh dear. You can either manually enter in the missing line or apply the attached patch as before (you need a clean res_parking.c which you can get by deleting the file and then doing cvs co asterisk again). This patch works on my system updated to the latest cvs. Iain --On Wednesday, March 10, 2004 4:54 pm -0500 mattf <mattf@vicimarketing.com> wrote:> Here's my patch results: > > [root@machine asterisk]# patch -p0 < ./Parking.patch > patching file res/res_parking.c > Hunk #1 FAILED at 25. > Hunk #2 succeeded at 228 (offset 13 lines). > Hunk #3 succeeded at 288 (offset 12 lines). > Hunk #4 succeeded at 408 (offset 13 lines). > 1 out of 4 hunks FAILED -- saving rejects to file res/res_parking.c.rej > > [root@VICIast1 asterisk]# cat res/res_parking.c.rej > *************** > *** 25,30 **** > #include <asterisk/musiconhold.h> > #include <asterisk/config.h> > #include <asterisk/cli.h> > #include <stdlib.h> > #include <errno.h> > #include <unistd.h> > --- 25,31 ---- > #include <asterisk/musiconhold.h> > #include <asterisk/config.h> > #include <asterisk/cli.h> > + #include <asterisk/indications.h> > #include <stdlib.h> > #include <errno.h> > #include <unistd.h> > > > is the first fail a bad thing? > > This is CVS from 15 minutes ago. > > Thanks, > > MATT--- > > > > -----Original Message----- > From: Iain Stevenson [mailto:iain@iainstevenson.com] > Sent: Wednesday, March 10, 2004 4:33 PM > To: asterisk-users@lists.digium.com > Subject: Re: [Asterisk-Users] Outbound Transfer and the # key > > > > Try the attached patch. Go to your asterisk root directory and type: > > patch -p0 < path_to_patch/Parking.patch > > .. then rebuild asterisk. > > Iain > > > > --On Wednesday, March 10, 2004 7:43 am -0500 John Congdon <john@z1g.com> > wrote: > >> I have applied the patch and restarted Asterisk. >> >> But it still only requires a single # to transfer. >> Did I possibly miss something? >> >> This is just to show that it was applied. >> >> [root@pbx asterisk]# pwd >> /usr/src/asterisk >> [root@pbx asterisk]# patch -p0 < ../old_asterisk/doublehash.patch >> patching file res/res_parking.c >> Reversed (or previously applied) patch detected! Assume -R? [n] >> Apply anyway? [n] >> Skipping patch. >> 3 out of 3 hunks ignored -- saving rejects to file res/res_parking.c.rej >> >> >> John >> >> >> >> On Mar 9, 2004, at 4:53 PM, mattf wrote: >> >> There is a better way to deal with this, it's the doublehash patch. This >> patch makes it so you have to press the hash key twice to transfer a call >> instead of once as is default in Asterisk. >> >> Sad thing is that every time the parking code changes the patch has to >> change(sometimes twice a week) and I don't have a patch for the most >> recent CVS. I've asked numerous times for some wonderful >> Asterisk-code-God(please Mark ;)) to make it a configurable variable in >> the parking.conf file but noone seems to think it's worthy of doing. It's >> actually a rather simple code change from what I can guess reading the >> patch code. I've been told that the core developers(Mark) don't want to >> mess with doublehash, but maybe if enough people say they want it we can >> get them to make this harmless addition to the parking code. >> >> Here's a bug where it's been talked about: >> http://bugs.digium.com/bug_view_page.php?bug_id=0000885 >> >> MATT--- >> >> >> -----Original Message----- >> From: John Congdon [mailto:john@z1g.com] >> Sent: Tuesday, March 09, 2004 4:24 PM >> To: Asterisk Mailling List >> Subject: [Asterisk-Users] Outbound Transfer and the # key >> >> >> Has there been any resolution to this? >> >> Does anyone have a good way to allow >> someone to choose whether they want to >> be able to transfer a call vs send the # to >> the other end. >> >> Is there a simple way to change the Transfer >> key for # to *? >> >> >> John >> >> _______________________________________________ >> Asterisk-Users mailing list >> Asterisk-Users@lists.digium.com >> http://lists.digium.com/mailman/listinfo/asterisk-users >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users >> _______________________________________________ >> Asterisk-Users mailing list >> Asterisk-Users@lists.digium.com >> http://lists.digium.com/mailman/listinfo/asterisk-users >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users >> >> _______________________________________________ >> Asterisk-Users mailing list >> Asterisk-Users@lists.digium.com >> http://lists.digium.com/mailman/listinfo/asterisk-users >> To UNSUBSCRIBE or update options visit: >> http://lists.digium.com/mailman/listinfo/asterisk-users >> > > > > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users >