Adduser devel - Nov 2006 - Bug#212872: passwd: adduser should ask for password again if there is a mismatch

I just tried to add a test user in a fresh sid debootstrap and had a typo in
the re-typed password:

,----
| # adduser test2
| perl: warning: Setting locale failed.
| perl: warning: Please check that your locale settings:
|         LANGUAGE = (unset),
|         LC_ALL = (unset),
|         LANG = "en_US.UTF-8"
|     are supported and installed on your system.
| perl: warning: Falling back to the standard locale ("C").
| Adding user `test2'' ...
| Adding new group `test2'' (1001) ...
| Adding new user `test2'' (1001) with group `test2'' ...
| Creating home directory `/home/test2'' ...
| Copying files from `/etc/skel'' ...
| Enter new UNIX password: 
| Retype new UNIX password: 
| Sorry, passwords do not match
| passwd: Authentication information cannot be recovered
| passwd: password unchanged
| Undefined subroutine &main::NOEXPR called at /usr/sbin/adduser line 509,
<FIND> line 4.
`----

I would also prefer it if adduser would ask me again. Additionally please
notice the last line in the output about the missing subroutine.

regards
 Thorsten

This one time, at band camp, Thorsten Gunkel said:
> I just tried to add a test user in a fresh sid debootstrap and had a typo
in
> the re-typed password:
> 
> | Enter new UNIX password: 
> | Retype new UNIX password: 
> | Sorry, passwords do not match
> | passwd: Authentication information cannot be recovered
> | passwd: password unchanged
> | Undefined subroutine &main::NOEXPR called at /usr/sbin/adduser line
509, <FIND> line 4.
> `----
> 
> I would also prefer it if adduser would ask me again. Additionally please
> notice the last line in the output about the missing subroutine.
I think I''ve got the problem fixed.  I have applied the patch below in
svn - can you test to make sure it fixes it for you?

--- adduser     (revision 675)
+++ adduser     (working copy)
@@ -54,8 +54,9 @@
        import I18N::Langinfo qw(langinfo YESEXPR NOEXPR);
     };
     if ($@) {
-       *langinfo = sub { "^[yY]" };
-       *YESEXPR = sub { 1 };
+       *langinfo = sub { return shift; };
+       *YESEXPR  = sub { "^[yY]" };
+       *NOEXPR   = sub { "^[nN]" };
     }
 }


Thanks,
-- 
 -----------------------------------------------------------------
|   ,''''`.                                            Stephen
Gran |
|  : :'' :                                        sgran@debian.org |
|  `. `''                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20061125/28b18e54/attachment.pgp

On [Sat, 25.11.2006 02:18], Stephen Gran wrote:
> This one time, at band camp, Thorsten Gunkel said:
> > I just tried to add a test user in a fresh sid debootstrap and had a
typo in
> > the re-typed password:
> > | Enter new UNIX password: 
> > | Retype new UNIX password: 
> > | Sorry, passwords do not match
> > | passwd: Authentication information cannot be recovered
> > | passwd: password unchanged
> > | Undefined subroutine &main::NOEXPR called at /usr/sbin/adduser
line 509, <FIND> line 4.
> I think I''ve got the problem fixed.  I have applied the patch
below in
> svn - can you test to make sure it fixes it for you?
I changed the lines in the current unstable version and I seems to work
without problems:
,----
| Enter new UNIX password: 
| Retype new UNIX password: 
| Sorry, passwords do not match
| passwd: Authentication information cannot be recovered
| passwd: password unchanged
| Try again? [Y/n] y
| Enter new UNIX password: 
| Retype new UNIX password: 
| passwd: password updated successfully
`----

Thanks,
 Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20061125/07ad3b26/attachment.pgp

This one time, at band camp, Thorsten Gunkel said:
> On [Sat, 25.11.2006 02:18], Stephen Gran wrote:
> > This one time, at band camp, Thorsten Gunkel said:
> > > I just tried to add a test user in a fresh sid debootstrap and
had a typo in
> > > the re-typed password:
> > > | Enter new UNIX password: 
> > > | Retype new UNIX password: 
> > > | Sorry, passwords do not match
> > > | passwd: Authentication information cannot be recovered
> > > | passwd: password unchanged
> > > | Undefined subroutine &main::NOEXPR called at
/usr/sbin/adduser line 509, <FIND> line 4.
> 
> > I think I''ve got the problem fixed.  I have applied the patch
below in
> > svn - can you test to make sure it fixes it for you?
> 
> I changed the lines in the current unstable version and I seems to work
> without problems:
> ,----
> | Sorry, passwords do not match
> | passwd: Authentication information cannot be recovered
> | passwd: password unchanged
> | Try again? [Y/n] y
Great.

Marc, do you think we should try to push for this to go into etch?
There are no string changes, as this part is untranslated, and it seems
like a reasonably important bugfix to me.
-- 
 -----------------------------------------------------------------
|   ,''''`.                                            Stephen
Gran |
|  : :'' :                                        sgran@debian.org |
|  `. `''                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20061125/38007729/attachment.pgp

On Sat, Nov 25, 2006 at 01:41:51PM +0000, Stephen Gran
wrote:
> Marc, do you think we should try to push for this to go into etch?
I agree and plan to upload tomorrow.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835