Adduser devel - Jul 2006 - Bug#377701: More improvements for the program output

Package: adduser
Version: 3.92
Severity: normal
Tags: patch

Hi,

here is another round of updates concerning the program output. This time, 
I''ve tried to unify the usage of "aborting" and
"exiting". Moreover, I''ve
removed the three dots after "exiting", because that''s the
last message,
there''s nothing more to follow, hence, no need for an ellipsis.

I''ve also reworded the help texts in version() and usage(), to be more 
alike.

All of this is optional, of course, and you may choose freely what to apply.

Oh, one last thing: the patch to po/Makefile looks irrelevant, but it
isn''t.
Something seems to have happened to the last patch, you need to make sure 
that the target is indented with tabs, not tabs and space. Currently, the 
target adduser.pot fails and does not generate the pot file.

Regards,
Tobias

-- 
Tobias Toedter   | "I never forget a face, but in your case I''ll
be glad
Hamburg, Germany | to make an exception." -- Groucho Marx

Hi

On Mon, Jul 10, 2006 at 09:02:03PM +0200, Tobias Toedter
wrote:
> I''ve also reworded the help texts in version() and usage(), to be
more
> alike.
Looks good.
> All of this is optional, of course, and you may choose freely what to
apply.
I think, we should apply these patches (I did some remarks on them, see
below).

Thank you for your help, we really appreciate it.

>  # adduser: a utility to add users to the system
>  # addgroup: a utility to add groups to the system
> -my $version = "VERSION";
> +my $version = "3.92";
>  # deluser -- a utility to remove users from the system
>  # delgroup -- a utilty to remove groups from the system
> -my $version = "VERSION";
> +my $version = "3.92";
Don''t hardcode the version information here and keep the VERSION string
here, the build system will replace it.
>  if (($config{remove_home} || $config{remove_all_files} || $config{backup})
&& ($install_more_packages)) {
>      die (gtx("In order to use the --remove-home, --remove-all-files,
and --backup features,
>  you need to install the `perl-modules'' package. To accomplish
that, run
> -apt-get install perl-modules\n"));
> +apt-get install perl-modules.\n"));
I think we can ommit the trailing period, because it''s a line you can
c&p
to the command line.


J?rg

-- 
What did you do to the cat? It looks half-dead. -Schroedinger''s wife
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060710/52a15a67/attachment.pgp

On Mon, Jul 10, 2006 at 09:02:03PM +0200, Tobias Toedter
wrote:
> Oh, one last thing: the patch to po/Makefile looks irrelevant, but it
isn''t.
> Something seems to have happened to the last patch, you need to make sure 
> that the target is indented with tabs, not tabs and space. Currently, the 
> target adduser.pot fails and does not generate the pot file.
My bad. I apologize.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

tags #377701 confirmed pending
thanks

On Mon, Jul 10, 2006 at 09:02:03PM +0200, Tobias Toedter
wrote:
> here is another round of updates concerning the program output.
Committed to svn. I have also unified the usage of ellipses: Whenever
something is being done, the line ends with an ellipse. This does not
apply to "Not backing up stuff.", though.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

Processing commands for control@bugs.debian.org:
> tags #377701 confirmed pending
Bug#377701: More improvements for the program output
Tags were: patch
Tags added: confirmed, pending
> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)

On Friday 14 July 2006 20:59, you wrote:
> Committed to svn. I have also unified the usage of ellipses: Whenever
> something is being done, the line ends with an ellipse. This does not
> apply to "Not backing up stuff.", though.
This looks good, thanks. There are two minor typos, I''m not filing a
new bug
for them. In line 582, the opening quotes (`) are missing both times:

"Setting quota for user %s'' to values of user %s''
...\n"
should be
"Setting quota for user `%s'' to values of user `%s''
...\n"

Apart from that, I think the pot file should be ready to be sent 
to -l10n-english@l.d.o, what do you think?

Regards,
Tobias

-- 
Tobias Toedter   | Death has been proven to be 99% fatal in laboratory rats.
Hamburg, Germany |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url :
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060714/ac73ecd3/attachment.pgp

On Fri, Jul 14, 2006 at 10:34:16PM +0200, Tobias Toedter
wrote:
> On Friday 14 July 2006 20:59, you wrote:
> > Committed to svn. I have also unified the usage of ellipses: Whenever
> > something is being done, the line ends with an ellipse. This does not
> > apply to "Not backing up stuff.", though.
> 
> This looks good, thanks. There are two minor typos, I''m not filing
a new bug
> for them. In line 582, the opening quotes (`) are missing both times:
> 
> "Setting quota for user %s'' to values of user %s''
...\n"
> should be
> "Setting quota for user `%s'' to values of user `%s''
...\n"
Fixed.
> Apart from that, I think the pot file should be ready to be sent 
> to -l10n-english@l.d.o, what do you think?
I have already requested a cross-check on Jul 09 (see 
http://lists.debian.org/debian-l10n-english/2006/07/threads.html), and
nobody bothered to reply.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

Your message dated Sun, 16 Jul 2006 23:47:14 -0700
with message-id <E1G2Mss-0004sp-C7@spohr.debian.org>
and subject line Bug#377701: fixed in adduser 3.93
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

-------------- next part --------------
An embedded message was scrubbed...
From: Tobias Toedter <t.toedter@gmx.net>
Subject: More improvements for the program output
Date: Mon, 10 Jul 2006 21:02:03 +0200
Size: 14618
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060717/81b17010/attachment-0002.mht
-------------- next part --------------
An embedded message was scrubbed...
From: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Bug#377701: fixed in adduser 3.93
Date: Sun, 16 Jul 2006 23:47:14 -0700
Size: 3319
Url:
http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060717/81b17010/attachment-0003.mht