thr3ads.net - Adduser devel - [Adduser-devel] Bug#283110: adduser won''t add usernames containing dots [Nov 2004]

If this information is useful, please help other people find it:
Share via:

Jesús M. Navarro

2004-Nov-26 15:11 UTC

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

Package: adduser
Version: 3.59
Severity: important

Hi:

This is the behaviour:

mithrandir:~# adduser john.doe
adduser: Please enter a username consisting of a lower case letter
followed by lower case letters and numbers.  Use the `--force-badname''
option to allow underscores, and uppercase.

mithrandir:~# adduser --force-badname john.doe
adduser: To avoid problems, the username should consist of a letter or
underscore followed by letters, digits, underscores, and dashes. For
compatibility with Samba machine accounts $ is also supported at the
end of the username
mithrandir:~#

Still, useradd will gladly add these kind of usernames.  For all I know,
usernames containing dots used to be POSIX illegal, but they are illegal no
more.  chmod, for instance, will allow `chmod user:group whatever`
syntax (using colon instead of dot-separating old notation) just for this very
reason.
Since this bug impedes adding a legal (so I think) username, I think this
deserves the "important" level.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, ''testing'')
Architecture: i386 (i586)
Kernel: Linux 2.4.26-nav03
Locale: LANG=es_ES@euro, LC_CTYPE=es_ES@euro (ignored: LC_ALL set to es_ES@euro)

Versions of packages adduser depends on:
ii  debconf                     1.4.30.10    Debian configuration management sy
ii  passwd                      1:4.0.3-30.3 Change and administer password and
ii  perl-base                   5.8.4-3      The Pathologically Eclectic Rubbis

-- debconf information:
* adduser/homedir-permission: true

Michelle Konzack

2004-Nov-26 16:43 UTC

head link

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

--Xsn3knLL3qrmRbVI
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Am 2004-11-26 16:11:22, schrieb Jes=FAs M. Navarro:
> Still, useradd will gladly add these kind of usernames.  For all I=20
> know,
> usernames containing dots used to be POSIX illegal, but they are=20
> illegal no
> more.  chmod, for instance, will allow `chmod user:group whatever`
> syntax (using colon instead of dot-separating old notation) just for=20
> this very reason.
Are you sure ?
It works since POTATO...
> Since this bug impedes adding a legal (so I think) username, I think=20
> this
> deserves the "important" level.
I have changed it since the first WOODY Release...

File: adduser

Change the two things from
------------------------------------------------------------------------
$verbose =3D 1;			# should we be verbose?
$allow_badname =3D 0;		# should we allow bad names?
$ask_passwd =3D 1;		# ask for a passwd?

=2E..

# is name ok?
sub checkname {
    my ($name) =3D @_;
    if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/) {
------------------------------------------------------------------------

to
------------------------------------------------------------------------
$verbose =3D 1;			# should we be verbose?
$allow_badname =3D 1;		# should we allow bad names?
$ask_passwd =3D 1;		# ask for a passwd?

=2E..

# is name ok?
sub checkname {
    my ($name) =3D @_;
    if ($allow_badname && $name !~ /^[A-Za-z_][-_.A-Za-z0-9]*\$?$/) {
------------------------------------------------------------------------
                                                 ^
                            There is a added point

Greetings
Michelle

--=20
Linux-User #280138 with the Linux Counter, http://counter.li.org/=20
Michelle Konzack   Apt. 917                  ICQ #328449886
                   50, rue de Soultz         MSM LinuxMichi
0033/3/88452356    67100 Strasbourg/France   IRC #Debian (irc.icq.com)

--Xsn3knLL3qrmRbVI
Content-Type: application/pgp-signature; name="signature.pgp"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBp11PC0FPBMSS+BIRAk4IAJ47VvxwQ0/0UGUEM3ySrATh085CjQCeMPrl
pKF+4a4xAQ8JSoBgzZ4EWqo=a8Hd
-----END PGP SIGNATURE-----

--Xsn3knLL3qrmRbVI--

Jesús M. Navarro

2004-Nov-26 17:36 UTC

head link

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

Hi, Michelle:

El Viernes, 26 Noviembre 2004 17:43, Michelle Konzack
escribi=F3:> Am 2004-11-26 16:11:22, schrieb Jes=FAs M. Navarro:
> > Still, useradd will gladly add these kind of usernames.  For all I
> > know,
> > usernames containing dots used to be POSIX illegal, but they are
> > illegal no
> > more.  chmod, for instance, will allow `chmod user:group whatever`
> > syntax (using colon instead of dot-separating old notation) just for
> > this very reason.
>
> Are you sure ?
> It works since POTATO...
Well, the example I sent you in my first message has been tested on two=20
different boxes, both with current as 25/NOV/2004 Sarge packages.
[...]
> I have changed it since the first WOODY Release...
[...]

> # is name ok?
> sub checkname {
>     my ($name) =3D @_;
>     if ($allow_badname && $name !~ /^[A-Za-z_][-_.A-Za-z0-9]*\$?$/)
{
> ------------------------------------------------------------------------
>                                                  ^
>                             There is a added point
I think you will have to recheck that.  Your change seems to have been lost=20
somewhere along the way:

#!/usr/bin/perl
#
# adduser 3.59
#

[...]

# is name ok?
sub checkname {
    my ($name) =3D @_;
    if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/) {
                                                ^ See? No dot here
        print STDERR
"$0: ",_("To avoid problems, the username should consist of a
letter or
underscore followed by letters, digits, underscores, and dashes. For
compatibility with Samba machine accounts \$ is also supported at the
end of the username\n");
        exit 1;
    }
    elsif ($name !~ /^[a-z][a-z0-9\-]*$/) {
        if (!$allow_badname) {
            print STDERR
"$0: ",_("Please enter a username consisting of a lower case
letter
followed by lower case letters and numbers.  Use the `--force-badname''
option to allow underscores, and uppercase.\n");
            exit 1;
        }
        print _("Allowing use of questionable username.\n") if
($verbose);
    }
}

By the way, the last but one error message here should have to be changed to=20
"...Use the ''--force-badname'' option to allow undercores,
*dots* and=20
uppercase.\n".

Thanks for your interest.

Michelle Konzack

2004-Nov-26 18:10 UTC

head link

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

--sBcizk6cgRZY6rnJ
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jes=FAs,

Am 2004-11-26 18:36:21, schrieb Jes=FAs M. Navarro:> Hi, Michelle:
> >     if ($allow_badname && $name !~
/^[A-Za-z_][-_.A-Za-z0-9]*\$?$/) {
> >
------------------------------------------------------------------------
> >                                                  ^
> >                             There is a added point
>
> I think you will have to recheck that.  Your change seems to have been lost
???
> somewhere along the way:
>     if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/)
{
>                                                 ^ See? No dot here
This is why I have written: "This is a added point"

I have added the "." and now all is working fine for my 57 local
$USER because they can login with "firstname.lastname".
> By the way, the last but one error message here should have to be changed
to
> "...Use the ''--force-badname'' option to allow
undercores, *dots* and
> uppercase.\n".
Agreed.

Because I like this feature since years, I must change "adduser"
every time I upgrade my systems, I like to see this new feature
as standard in SARGE.
> Thanks for your interest.
Greetings
Michelle

--=20
Linux-User #280138 with the Linux Counter, http://counter.li.org/
Michelle Konzack   Apt. 917                  ICQ #328449886
                   50, rue de Soultz         MSM LinuxMichi
0033/3/88452356    67100 Strasbourg/France   IRC #Debian (irc.icq.com)

--sBcizk6cgRZY6rnJ
Content-Type: application/pgp-signature; name="signature.pgp"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBp3GuC0FPBMSS+BIRAvYyAJ9RvPTAX+N5oJxYHUU+j31C8+BLZACgp2Lm
Q24jpx4NfWDB9Ndgl5t+2AQ=1BX5
-----END PGP SIGNATURE-----

--sBcizk6cgRZY6rnJ--

Jesús M. Navarro

2004-Nov-27 18:59 UTC

head link

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

Hi, Marc:

El S=E1bado, 27 Noviembre 2004 14:33, Marc Haber
escribi=F3:> On Fri, Nov 26, 2004 at 06:36:21PM +0100, Jes=FAs M. Navarro wrote:
> > I think you will have to recheck that.  Your change seems to have been
> > lost somewhere along the way:
>
> Michelle has never submitted a patch for the Debian adduser package.
> She must be talking about a local patch to her local systems.
Yes, I misundernstood her.  I thought she was the package maintainer and she=20
was saying that she patched adduser by Woody version.
> I will see what I can do wrt the Debian package.
Well, these are my suggested changes:

***start patch***
721c721
<     if ($allow_badname && $name !~ /^[A-Za-z_][-_A-Za-z0-9]*\$?$/)
{
=2D-->     if ($allow_badname && $name !~
/^[A-Za-z_][\-_\.A-Za-z0-9]*\$?$/) {733,734c733,734
< followed by lower case letters and numbers.  Use the
`--force-badname''
< option to allow underscores, and uppercase.\n");
=2D--> followed by lower case letters, numbers or dashes.  Use the=20
`--force-badname''> option to allow underscores, dots, and uppercase.\n");***end patch***
TIA.

Debian Bug Tracking System

2005-May-06 12:33 UTC

head link

[Adduser-devel] Bug#283110: marked as done (adduser won''t add usernames containing dots)

Your message dated Fri, 6 May 2005 14:21:10 +0200
with message-id <20050506122110.GA17295@lefler.int.l21.ma.zugschlus.de>
and subject line Closing bugs
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 26 Nov 2004 15:12:05
+0000>From jmnavarrol@able.es Fri Nov 26 07:12:05 2004Return-path: <jmnavarrol@able.es>
Received: from smtp09.auna.com (smtp09.retemail.es) [62.81.186.19] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CXhlV-0001Ss-00; Fri, 26 Nov 2004 07:12:05 -0800
Received: from mithrandir.intranet ([212.97.189.242]) by smtp09.retemail.es
          (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP
          id
<20041126151133.DRRK1300.smtp09.retemail.es@mithrandir.intranet>;
          Fri, 26 Nov 2004 16:11:33 +0100
Received: by mithrandir.intranet (Postfix, from userid 108)
	id EFBF353D8B; Fri, 26 Nov 2004 16:11:29 +0100 (CET)
Received: from mithrandir.intranet (localhost [127.0.0.1])
	by mithrandir.intranet (Postfix) with ESMTP id 1A9C253D6C;
	Fri, 26 Nov 2004 16:11:23 +0100 (CET)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: =?iso-8859-15?q?Jes=FAs_M=2E_Navarro?= <jmnavarrol@able.es>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: adduser won''t add usernames containing dots
X-Mailer: reportbug 2.63
Date: Fri, 26 Nov 2004 16:11:22 +0100
Message-Id: <20041126151123.1A9C253D6C@mithrandir.intranet>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: adduser
Version: 3.59
Severity: important

Hi:

This is the behaviour:

mithrandir:~# adduser john.doe
adduser: Please enter a username consisting of a lower case letter
followed by lower case letters and numbers.  Use the `--force-badname''
option to allow underscores, and uppercase.

mithrandir:~# adduser --force-badname john.doe
adduser: To avoid problems, the username should consist of a letter or
underscore followed by letters, digits, underscores, and dashes. For
compatibility with Samba machine accounts $ is also supported at the
end of the username
mithrandir:~#

Still, useradd will gladly add these kind of usernames.  For all I know,
usernames containing dots used to be POSIX illegal, but they are illegal no
more.  chmod, for instance, will allow `chmod user:group whatever`
syntax (using colon instead of dot-separating old notation) just for this very
reason.
Since this bug impedes adding a legal (so I think) username, I think this
deserves the "important" level.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, ''testing'')
Architecture: i386 (i586)
Kernel: Linux 2.4.26-nav03
Locale: LANG=es_ES@euro, LC_CTYPE=es_ES@euro (ignored: LC_ALL set to es_ES@euro)

Versions of packages adduser depends on:
ii  debconf                     1.4.30.10    Debian configuration management sy
ii  passwd                      1:4.0.3-30.3 Change and administer password and
ii  perl-base                   5.8.4-3      The Pathologically Eclectic Rubbis

-- debconf information:
* adduser/homedir-permission: true

---------------------------------------
Received: (at 283110-done) by bugs.debian.org; 6 May 2005 12:22:10
+0000>From mh+debian-packages@zugschlus.de Fri May 06 05:22:10 2005Return-path: <mh+debian-packages@zugschlus.de>
Received: from 5301d.unt0.torres.l21.ma.zugschlus.de
(torres.int.l21.ma.zugschlus.de) [217.151.83.1] (Debian-exim)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DU1qM-0003FP-00; Fri, 06 May 2005 05:22:10 -0700
Received: from lefler.int.l21.ma.zugschlus.de ([192.168.130.38])
	by torres.int.l21.ma.zugschlus.de with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.50)
	id 1DU1pQ-0002Pk-2p; Fri, 06 May 2005 14:21:12 +0200
Received: from mh by lefler.int.l21.ma.zugschlus.de with local (Exim 4.50)
	id 1DU1pP-0004fU-0I; Fri, 06 May 2005 14:21:11 +0200
Date: Fri, 6 May 2005 14:21:10 +0200
From: Marc Haber <mh+debian-packages@zugschlus.de>
To: 293559-done@bugs.debian.org, 283110-done@bugs.debian.org,
	287535-done@bugs.debian.org, 268841-done@bugs.debian.org,
	268837-done@bugs.debian.org, 286227-done@bugs.debian.org,
	268402-done@bugs.debian.org, 278937-done@bugs.debian.org,
	270266-done@bugs.debian.org, 279659-done@bugs.debian.org,
	273010-done@bugs.debian.org, 271142-done@bugs.debian.org,
	271829-done@bugs.debian.org, 231809-done@bugs.debian.org
Cc: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Closing bugs
Message-ID: <20050506122110.GA17295@lefler.int.l21.ma.zugschlus.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: 283110-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 
X-CrossAssassin-Score: 11

These bugs have been tagged as fixed-in-experimental, and are now
being closed completely. That should have happened long ago.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don''t trust Computers. They | Mailadresse
im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835

Adduser devel - Nov 2004 - Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: adduser won''t add usernames containing dots

[Adduser-devel] Bug#283110: marked as done (adduser won''t add usernames containing dots)