I''d like reviewers for: 6701930 vna should allow the caller to name the VNIC The webrev is at http://dme.org/solaris/webrev/6649354/. There is also a fix for 6649354 there, but I haven''t finished (started?) testing it yet.
Hi Dave, David Edmondson wrote:> I''d like reviewers for: > 6701930 vna should allow the caller to name the VNIC >You might want to change the comment start from line 152 to reflect current code change: "with this MAC address" -> "with this MAC address and name". Others looks good to me :). Max> The webrev is at http://dme.org/solaris/webrev/6649354/. There is also > a fix for 6649354 there, but I haven''t finished (started?) testing it > yet. > > _______________________________________________ > xen-discuss mailing list > xen-discuss@opensolaris.org >
Thanks Max - I updated the comment.
David Edmondson wrote:> I''d like reviewers for: > 6701930 vna should allow the caller to name the VNIC > > The webrev is at http://dme.org/solaris/webrev/6649354/. There is also > a fix for 6649354 there, but I haven''t finished (started?) testing it > yet.242 (void) fprintf(stderr, "Incorrect number of arguments - " 243 "must have 0, 1, 2 or 3.\n"); you might want to change 243 to something like "must have 3 or less" otherwise, looks fine to me. Michael -- Michael Schuster http://blogs.sun.com/recursion Recursion, n.: see ''Recursion''
Michael Schuster wrote:> David Edmondson wrote: >> I''d like reviewers for: >> 6701930 vna should allow the caller to name the VNIC >> >> The webrev is at http://dme.org/solaris/webrev/6649354/. There is also >> a fix for 6649354 there, but I haven''t finished (started?) testing it >> yet. > > > 242 (void) fprintf(stderr, "Incorrect number of > arguments - " > 243 "must have 0, 1, 2 or 3.\n"); > > you might want to change 243 to something like "must have 3 or less"Shouldn''t that be "3 or fewer" ? /me runs from the ensuing grammar war. :-) -Ryan> > otherwise, looks fine to me. > > Michael
Ryan Scott wrote:>> you might want to change 243 to something like "must have 3 or less" > > Shouldn''t that be "3 or fewer" ? > > /me runs from the ensuing grammar war.hey, English is only my second language ... or third, if Austrian counts as seperate from German ;-) Michael -- Michael Schuster http://blogs.sun.com/recursion Recursion, n.: see ''Recursion''