thr3ads.net - Xen devel - [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model [Jun 2011]

If this information is useful, please help other people find it:
Share via:

Wei Liu

2011-Jun-07 06:48 UTC

[Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
Author: Wei Liu <liuw@liuw.name>
Date:   Tue Jun 7 14:26:34 2011 +0800

    libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
    
    This unifies upstream qemu and Xen''s qemu-dm startup option.
    
    Signed-off-by: Wei Liu <liuw@liuw.name>

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 47a51c8..d53a20d 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc
*gc,
                       "-d", libxl__sprintf(gc, "%d",
info->domid), NULL);
 
     if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name,
NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
 
     if (info->vnc) {
         char *vncarg;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini

2011-Jun-07 11:52 UTC

head link

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

On Tue, 7 Jun 2011, Wei Liu wrote:> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> Author: Wei Liu <liuw@liuw.name>
> Date:   Tue Jun 7 14:26:34 2011 +0800
> 
>     libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
>     
>     This unifies upstream qemu and Xen''s qemu-dm startup option.
>     
>     Signed-off-by: Wei Liu <liuw@liuw.name>
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 47a51c8..d53a20d 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -95,7 +95,7 @@ static char **
libxl__build_device_model_args_old(libxl__gc *gc,
>                        "-d", libxl__sprintf(gc, "%d",
info->domid), NULL);
>  
>      if (info->dom_name)
> -        flexarray_vappend(dm_args, "-domain-name",
info->dom_name, NULL);
> +        flexarray_vappend(dm_args, "-name", info->dom_name,
NULL);
>  
>      if (info->vnc) {
>          char *vncarg;
considering that libxl__build_device_model_args_old is only meant to be
used with the old qemu-xen that we are not going to upgrade anymore, I
don''t think it is worth to try to update its command line options.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Wei Liu

2011-Jun-07 12:11 UTC

head link

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:> On Tue, 7 Jun 2011, Wei Liu wrote:
>> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
>> Author: Wei Liu <liuw@liuw.name>
>> Date:   Tue Jun 7 14:26:34 2011 +0800
>>
>>     libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
>>
>>     This unifies upstream qemu and Xen''s qemu-dm startup
option.
>>
>>     Signed-off-by: Wei Liu <liuw@liuw.name>
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 47a51c8..d53a20d 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -95,7 +95,7 @@ static char **
libxl__build_device_model_args_old(libxl__gc *gc,
>>                        "-d", libxl__sprintf(gc,
"%d", info->domid), NULL);
>>
>>      if (info->dom_name)
>> -        flexarray_vappend(dm_args, "-domain-name",
info->dom_name, NULL);
>> +        flexarray_vappend(dm_args, "-name",
info->dom_name, NULL);
>>
>>      if (info->vnc) {
>>          char *vncarg;
>
> considering that libxl__build_device_model_args_old is only meant to be
> used with the old qemu-xen that we are not going to upgrade anymore, I
> don''t think it is worth to try to update its command line options.
>
Well, the device_model_{override,version} are not working for pv now.
So I consider this patch a workaround for using upstream qemu as pure
pv backend.

I''m still waiting for IanJ''s re-factoring of libxl. Hope that
could
get a better implementation.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Wei Liu

2011-Jun-07 12:16 UTC

head link

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

On Tue, Jun 07, 2011 at 12:52:03PM +0100, Stefano Stabellini
wrote:> On Tue, 7 Jun 2011, Wei Liu wrote:
> > commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> > Author: Wei Liu <liuw@liuw.name>
> > Date:   Tue Jun 7 14:26:34 2011 +0800
> > 
> >     libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
> >     
> >     This unifies upstream qemu and Xen''s qemu-dm startup
option.
> >     
> >     Signed-off-by: Wei Liu <liuw@liuw.name>
> > 
> > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> > index 47a51c8..d53a20d 100644
> > --- a/tools/libxl/libxl_dm.c
> > +++ b/tools/libxl/libxl_dm.c
> > @@ -95,7 +95,7 @@ static char **
libxl__build_device_model_args_old(libxl__gc *gc,
> >                        "-d", libxl__sprintf(gc,
"%d", info->domid), NULL);
> >  
> >      if (info->dom_name)
> > -        flexarray_vappend(dm_args, "-domain-name",
info->dom_name, NULL);
> > +        flexarray_vappend(dm_args, "-name",
info->dom_name, NULL);
> >  
> >      if (info->vnc) {
> >          char *vncarg;
> 
> considering that libxl__build_device_model_args_old is only meant to be
> used with the old qemu-xen that we are not going to upgrade anymore, I
> don''t think it is worth to try to update its command line options.
Well, device_model_{override,version} are not working for pure pv. I
consider this patch a workaround for using upstream qemu as pure pv
backend.

I hope that IanJ''s re-factoring of libxl will get a better
implementation of this.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini

2011-Jun-07 12:54 UTC

head link

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

On Tue, 7 Jun 2011, Wei Liu wrote:> On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Tue, 7 Jun 2011, Wei Liu wrote:
> >> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> >> Author: Wei Liu <liuw@liuw.name>
> >> Date:   Tue Jun 7 14:26:34 2011 +0800
> >>
> >>     libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
> >>
> >>     This unifies upstream qemu and Xen''s qemu-dm startup
option.
> >>
> >>     Signed-off-by: Wei Liu <liuw@liuw.name>
> >>
> >> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> >> index 47a51c8..d53a20d 100644
> >> --- a/tools/libxl/libxl_dm.c
> >> +++ b/tools/libxl/libxl_dm.c
> >> @@ -95,7 +95,7 @@ static char **
libxl__build_device_model_args_old(libxl__gc *gc,
> >>                        "-d", libxl__sprintf(gc,
"%d", info->domid), NULL);
> >>
> >>      if (info->dom_name)
> >> -        flexarray_vappend(dm_args, "-domain-name",
info->dom_name, NULL);
> >> +        flexarray_vappend(dm_args, "-name",
info->dom_name, NULL);
> >>
> >>      if (info->vnc) {
> >>          char *vncarg;
> >
> > considering that libxl__build_device_model_args_old is only meant to
be
> > used with the old qemu-xen that we are not going to upgrade anymore, I
> > don''t think it is worth to try to update its command line
options.
> >
> 
> Well, the device_model_{override,version} are not working for pv now.
> So I consider this patch a workaround for using upstream qemu as pure
> pv backend.
> 
> I''m still waiting for IanJ''s re-factoring of libxl. Hope
that could
> get a better implementation.
> 
IanJ is not going to touch this code AFAIK, so you can go ahead and
write a proper patch for that.
--8323329-719725572-1307451255=:12963
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--8323329-719725572-1307451255=:12963--

Ian Campbell

2011-Jun-07 12:54 UTC

head link

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

On Tue, 2011-06-07 at 13:16 +0100, Wei Liu wrote:> On Tue, Jun 07, 2011 at 12:52:03PM +0100, Stefano Stabellini wrote:
> > On Tue, 7 Jun 2011, Wei Liu wrote:
> > > commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> > > Author: Wei Liu <liuw@liuw.name>
> > > Date:   Tue Jun 7 14:26:34 2011 +0800
> > > 
> > >     libxl: use ''-name'' instead of deprecated
''-domain-name'' for device model.
> > >     
> > >     This unifies upstream qemu and Xen''s qemu-dm startup
option.
> > >     
> > >     Signed-off-by: Wei Liu <liuw@liuw.name>
> > > 
> > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> > > index 47a51c8..d53a20d 100644
> > > --- a/tools/libxl/libxl_dm.c
> > > +++ b/tools/libxl/libxl_dm.c
> > > @@ -95,7 +95,7 @@ static char **
libxl__build_device_model_args_old(libxl__gc *gc,
> > >                        "-d", libxl__sprintf(gc,
"%d", info->domid), NULL);
> > >  
> > >      if (info->dom_name)
> > > -        flexarray_vappend(dm_args, "-domain-name",
info->dom_name, NULL);
> > > +        flexarray_vappend(dm_args, "-name",
info->dom_name, NULL);
> > >  
> > >      if (info->vnc) {
> > >          char *vncarg;
> > 
> > considering that libxl__build_device_model_args_old is only meant to
be
> > used with the old qemu-xen that we are not going to upgrade anymore, I
> > don''t think it is worth to try to update its command line
options.
> 
> Well, device_model_{override,version} are not working for pure pv.
I think it would be preferable to tackle this directly rather than
working around it.
>  I
> consider this patch a workaround for using upstream qemu as pure pv
> backend.
> 
> I hope that IanJ''s re-factoring of libxl will get a better
> implementation of this.
I wasn''t aware of any intention (by IanJ or otherwise) to refactor
anything in this particular area.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Xen devel - Jun 2011 - [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

[Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model

Re: [Xen-devel] [PATCH] libxl: use ''-name'' instead of deprecated ''-domain-name'' for device model