Christoph Egger
2010-Jan-11 17:09 UTC
[Xen-devel] [PATCH][TOOLS] blktap: make memshr optional
Hi! Attached patch makes memshr optional for blktap/blktap2. This fixes build for platforms where memshr isn''t build on. While there, make indentation consistent. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Jan-12 17:27 UTC
Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional
Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr
optional"):> Attached patch makes memshr optional for blktap/blktap2.
> This fixes build for platforms where memshr isn''t build on.
That and ...
> While there, make indentation consistent.
... this should be separated out, surely.
Mixing up a whitespace change with anything else is a recipe for
making things hard to track down.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2010-Jan-12 17:41 UTC
Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional
On 12/01/2010 17:27, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:> Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr > optional"): >> Attached patch makes memshr optional for blktap/blktap2. >> This fixes build for platforms where memshr isn''t build on. > > That and ... > >> While there, make indentation consistent. > > ... this should be separated out, surely. > > Mixing up a whitespace change with anything else is a recipe for > making things hard to track down.In this rare case it looked okay to me, as the whitespace changes are exactly co-located with the patch''s semantic changes. So the semantic changes remain pretty clear in the diff. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel