Tomonari Horikoshi
2009-Feb-20 03:29 UTC
[Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()
Hi I think the "flush" is necessary. When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". What do you think? Signed-off-by: Tomonari Horikoshi <t.horikoshi@jp.fujitsu.com> Best regards, Tomonari Horikoshi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2009-Feb-20 11:40 UTC
Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()
Tomonari Horikoshi wrote:> Hi > > I think the "flush" is necessary. > When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". > > What do you think? > >I don''t think that calling bdrv_aio_flush is a good idea since it is asyncronous and right after the call we are going to close the device without waiting for completion. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Feb-23 16:41 UTC
Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] ioemu : add flush in
ide_unplug_harddisks()"):> Tomonari Horikoshi wrote:
> > I think the "flush" is necessary.
> > When "ioemu ide device" changes into "vbd" by
"ide_unplug_harddisks()".
>
> I don''t think that calling bdrv_aio_flush is a good idea since it
is
> asyncronous and right after the call we are going to close the device
> without waiting for completion.
Yes, bdrv_aio_flush is wrong I think.
This seems related to the discussion we had in January. As I wrote
in
http://lists.xensource.com/archives/html/xen-devel/2009-01/msg00165.html
it seems to me that the guest should know about be able to flush
for itself ? After all we implement the IDE flush cache command.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Tomonari Horikoshi
2009-Feb-23 23:46 UTC
Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()
Hi. Thank you for the comment. I have understood that it is a best approach to use the IDE flush cache command. I''m sorry I had overlooked the thread. Best regards, Tomonari Horikoshi Ian Jackson san wrote:---------------------- Sent: Mon, 23 Feb 2009 16:41:16 +0000 Subject: Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks() > "): > > Tomonari Horikoshi wrote: > > > I think the "flush" is necessary. > > > When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". > > > > I don''t think that calling bdrv_aio_flush is a good idea since it is > > asyncronous and right after the call we are going to close the device > > without waiting for completion. > > Yes, bdrv_aio_flush is wrong I think. > > This seems related to the discussion we had in January. As I wrote > in > http://lists.xensource.com/archives/html/xen-devel/2009-01/msg00165.html > it seems to me that the guest should know about be able to flush > for itself ? After all we implement the IDE flush cache command. > > Ian. >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel