Christoph Egger
2011-Apr-13 10:35 UTC
[Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
Cleanup for ASID emulation: - Use C99 integer types for asid numbers - asid.c: consistently use ''v'' instead of ''curr'' - Introduce svm_invlpga() used in ASID emulation patch Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Apr-13 13:06 UTC
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Cleanup for ASID emulation: > - Use C99 integer types for asid numbers> - asid.c: consistently use ''v'' instead of ''curr''On what planet is that an improvement?? We use ''curr'' as a convenient idiom to represent cached current. Whereas ''v'' is supposed to represent an arbitrary vcpu. I know it costs three extra characters per use, but it does make code easier to understand. -- Keir> - Introduce svm_invlpga() used in ASID emulation patch > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-Apr-13 13:20 UTC
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote:> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Cleanup for ASID emulation: > > - Use C99 integer types for asid numbers > > > > - asid.c: consistently use ''v'' instead of ''curr'' > > On what planet is that an improvement?? > > We use ''curr'' as a convenient idiom to represent cached current. Whereas > ''v'' is supposed to represent an arbitrary vcpu.Oh, that''s the difference. I thought ''curr'' is just another random name for an arbitrary vcpu. I will resend the patch w/o that hunk.> > I know it costs three extra characters per use, but it does make code > easier to understand. > > -- Keir > > > - Introduce svm_invlpga() used in ASID emulation patch > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Apr-13 13:28 UTC
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
On 13/04/2011 14:20, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>> Cleanup for ASID emulation: >>> - Use C99 integer types for asid numbers >>> >>> - asid.c: consistently use ''v'' instead of ''curr'' >> >> On what planet is that an improvement?? >> >> We use ''curr'' as a convenient idiom to represent cached current. Whereas >> ''v'' is supposed to represent an arbitrary vcpu. > > Oh, that''s the difference. I thought ''curr'' is just another random name for an > arbitrary vcpu. > > I will resend the patch w/o that hunk.I already applied the two cleanups that I didn''t mind, as two separate changesets. And I''ve nacked your main patch so you can go take a look at that. :-) -- Keir>> >> I know it costs three extra characters per use, but it does make code >> easier to understand. >> >> -- Keir >> >>> - Introduce svm_invlpga() used in ASID emulation patch >>> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-Apr-13 13:49 UTC
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
On 04/13/11 15:20, Christoph Egger wrote:> On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >> On 13/04/2011 11:35, "Christoph Egger"<Christoph.Egger@amd.com> wrote: >>> Cleanup for ASID emulation: >>> - Use C99 integer types for asid numbers >>> >>> - asid.c: consistently use ''v'' instead of ''curr'' >> >> On what planet is that an improvement?? >> >> We use ''curr'' as a convenient idiom to represent cached current. Whereas >> ''v'' is supposed to represent an arbitrary vcpu. > > Oh, that''s the difference. I thought ''curr'' is just another random name for an > arbitrary vcpu. > > I will resend the patch w/o that hunk. > >> >> I know it costs three extra characters per use, but it does make code >> easier to understand. >> >> -- Keir >> >>> - Introduce svm_invlpga() used in ASID emulation patch >>> >>> Signed-off-by: Christoph Egger<Christoph.Egger@amd.com>Here we go. Cleanup for ASID emulation: - Use C99 integer types for asid numbers - Introduce svm_invlpga() used in ASID emulation patch Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-Apr-13 14:27 UTC
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
On 04/13/11 15:28, Keir Fraser wrote:> On 13/04/2011 14:20, "Christoph Egger"<Christoph.Egger@amd.com> wrote: > >> On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >>> On 13/04/2011 11:35, "Christoph Egger"<Christoph.Egger@amd.com> wrote: >>>> Cleanup for ASID emulation: >>>> - Use C99 integer types for asid numbers >>>> >>>> - asid.c: consistently use ''v'' instead of ''curr'' >>> >>> On what planet is that an improvement?? >>> >>> We use ''curr'' as a convenient idiom to represent cached current. Whereas >>> ''v'' is supposed to represent an arbitrary vcpu. >> >> Oh, that''s the difference. I thought ''curr'' is just another random name for an >> arbitrary vcpu. >> >> I will resend the patch w/o that hunk. > > I already applied the two cleanups that I didn''t mind, as two separate > changesets.Thanks.> And I''ve nacked your main patch so you can go take a look at > that. :-)Just sent my comments. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel