Xen devel - Apr 2011 - pt_irq_time_out() dropping d->event_lock before calling pirq_guest_eoi()

What is the reason for this? irq_desc''s lock nests inside
d->event_lock,
and not having to drop the lock early would not only allow the two loops
to be folded, but also to call a short cut version of pirq_guest_eoi()
that already obtained the pirq->irq mapping (likely going to be created
when splitting the d->nr_pirqs sized arrays I''m working on
currently).

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On 08.04.11 at 12:44, "Jan Beulich"
<JBeulich@novell.com> wrote:
> What is the reason for this? irq_desc''s lock nests inside
d->event_lock,
> and not having to drop the lock early would not only allow the two loops
> to be folded, but also to call a short cut version of pirq_guest_eoi()
> that already obtained the pirq->irq mapping (likely going to be created
> when splitting the d->nr_pirqs sized arrays I''m working on
currently).
Actually, this is the only case where pirq_guest_eoi() gets called without
holding d->event_lock, so it rather smells like a mistake; I''ll go
forward
folding the second loop into the first, and only undo if there''s an
actual
reason for how things are currently.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel