Jan Beulich
2011-Mar-17 16:45 UTC
[Xen-devel] serial console driver using release_irq()/setup_irq() on suspend/resume
Keir, is there any particular reason this is being done this way, other than having made the change in 15259:35e38c9048c8 very simple? I''m asking because in general, with no modules, Xen ought to not need setup_irq() post-init (for release_irq() the serial driver is actually the only consumer), and after fiddling with request_irq() callers this is now the only one needing the function to be in .text. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Mar-17 17:01 UTC
[Xen-devel] Re: serial console driver using release_irq()/setup_irq() on suspend/resume
On 17/03/2011 16:45, "Jan Beulich" <JBeulich@novell.com> wrote:> Keir, > > is there any particular reason this is being done this way, other than > having made the change in 15259:35e38c9048c8 very simple? I''m > asking because in general, with no modules, Xen ought to not need > setup_irq() post-init (for release_irq() the serial driver is actually the > only consumer), and after fiddling with request_irq() callers this is > now the only one needing the function to be in .text.I expect it was done that way for simplicity, so that resume looks like boot-time init. Feel free to mess with it and make a more customised streamlined resume path. -- Keir> Jan >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel