Jimi Xenidis
2006-Nov-28 22:09 UTC
[Xen-devel] [xenppc-unstable] [XEN][POWERPC] secondary_cpu_init() does not return.
I messed up on filtering so I send manually # HG changeset patch # User Jimi Xenidis <jimix@watson.ibm.com> # Node ID a2a4a6bdc5cdedf3fe90626de9b16c9ee898f178 # Parent a8e67a19c3255a6bbc0aaa5c9e1736f1ddd76f6c [XEN][POWERPC] secondary_cpu_init() does not return. Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com> --- xen/arch/powerpc/exceptions.h | 2 +- xen/arch/powerpc/setup.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff -r a8e67a19c325 -r a2a4a6bdc5cd xen/arch/powerpc/exceptions.h --- a/xen/arch/powerpc/exceptions.h Tue Nov 28 10:33:53 2006 -0500 +++ b/xen/arch/powerpc/exceptions.h Tue Nov 28 16:43:53 2006 -0500 @@ -52,5 +52,5 @@ extern char exception_vectors[]; extern char exception_vectors[]; extern char exception_vectors_end[]; extern int spin_start[]; -extern int secondary_cpu_init(int cpuid, unsigned long r4); +extern void secondary_cpu_init(int cpuid, unsigned long r4); #endif diff -r a8e67a19c325 -r a2a4a6bdc5cd xen/arch/powerpc/setup.c --- a/xen/arch/powerpc/setup.c Tue Nov 28 10:33:53 2006 -0500 +++ b/xen/arch/powerpc/setup.c Tue Nov 28 16:43:53 2006 -0500 @@ -266,7 +266,7 @@ static int kick_secondary_cpus(int maxcp } /* This is the first C code that secondary processors invoke. */ -int secondary_cpu_init(int cpuid, unsigned long r4) +void secondary_cpu_init(int cpuid, unsigned long r4) { struct vcpu *vcpu; @@ -284,7 +284,7 @@ int secondary_cpu_init(int cpuid, unsign idle_vcpu[cpuid] = current; startup_cpu_idle_loop(); - while(1); + panic("should never get here\n"); } static void __init __start_xen(multiboot_info_t *mbi) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel