Fix the typo introduced by changeset 19446: 2ef77b4bdf58.
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
diff -r fb3e1e84d8f4 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py Wed May 06 12:40:51 2009 +0100
+++ b/tools/python/xen/xm/main.py Thu May 07 10:45:47 2009 +0800
@@ -2197,7 +2197,7 @@ def xm_pci_list_assignable_devices(args)
devs = server.xend.node.pciinfo()
- fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x:%(func)01x"
+ fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x.%(func)01x"
for x in devs:
pci = parse_pci_info(x)
print fmt_str % pci
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Simon Horman
2009-May-08 00:55 UTC
Re: [Xen-devel] [PATCH] xend: fix the pci BDF format string
On Thu, May 07, 2009 at 10:55:40AM +0800, Cui, Dexuan wrote:> Fix the typo introduced by changeset 19446: 2ef77b4bdf58.Hi, I can confirm that this patch fixes the problem, but would it be possible to have a more descriptive changelog to avoid having to look up what it was that 19446:2ef77b4bdf58 did? Perhaps: xend: Fix the PCI BDF format string used in the output of xm pci-list-assignable-devices This fixes a typo introduced by changeset 19446: 2ef77b4bdf58> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> > > diff -r fb3e1e84d8f4 tools/python/xen/xm/main.py > --- a/tools/python/xen/xm/main.py Wed May 06 12:40:51 2009 +0100 > +++ b/tools/python/xen/xm/main.py Thu May 07 10:45:47 2009 +0800 > @@ -2197,7 +2197,7 @@ def xm_pci_list_assignable_devices(args) > > devs = server.xend.node.pciinfo() > > - fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x:%(func)01x" > + fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x.%(func)01x" > for x in devs: > pci = parse_pci_info(x) > print fmt_str % pci-- Simon Horman VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-May-08 02:02 UTC
RE: [Xen-devel] [PATCH] xend: fix the pci BDF format string
Sorry, I should have used a better description. Now the patch has been checked in with the description... Anyway, we can use ''hg annotate tools/python/xen/xm/main.py" to locate which c/s changed that line easily. Thanks, -- Dexuan -----Original Message----- From: Simon Horman [mailto:horms@verge.net.au] Sent: 2009年5月8日 8:55 To: Cui, Dexuan Cc: Keir Fraser; xen-devel@lists.xensource.com; Yosuke Iwamatsu Subject: Re: [Xen-devel] [PATCH] xend: fix the pci BDF format string On Thu, May 07, 2009 at 10:55:40AM +0800, Cui, Dexuan wrote:> Fix the typo introduced by changeset 19446: 2ef77b4bdf58.Hi, I can confirm that this patch fixes the problem, but would it be possible to have a more descriptive changelog to avoid having to look up what it was that 19446:2ef77b4bdf58 did? Perhaps: xend: Fix the PCI BDF format string used in the output of xm pci-list-assignable-devices This fixes a typo introduced by changeset 19446: 2ef77b4bdf58> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> > > diff -r fb3e1e84d8f4 tools/python/xen/xm/main.py > --- a/tools/python/xen/xm/main.py Wed May 06 12:40:51 2009 +0100 > +++ b/tools/python/xen/xm/main.py Thu May 07 10:45:47 2009 +0800 > @@ -2197,7 +2197,7 @@ def xm_pci_list_assignable_devices(args) > > devs = server.xend.node.pciinfo() > > - fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x:%(func)01x" > + fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x.%(func)01x" > for x in devs: > pci = parse_pci_info(x) > print fmt_str % pci-- Simon Horman VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-May-08 02:38 UTC
Re: [Xen-devel] [PATCH] xend: fix the pci BDF format string
On Fri, May 08, 2009 at 10:02:42AM +0800, Cui, Dexuan wrote:> Sorry, I should have used a better description. Now the patch has been checked in with the description... > Anyway, we can use ''hg annotate tools/python/xen/xm/main.py" to locate which c/s changed that line easily.Sorry for the bother, I didn''t realise it had already been checked in. Thanks for spotting the problem, I had missed it. -- Simon Horman VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xia, Wayne
2009-May-08 03:20 UTC
[Xen-devel] lspci can''t display the size and address of Expansion Rom in Domain0
Hi,
Recently I confront the problem as follows:
In my computer(X58 mother board, Nvidia 8400 graphic card), I want to
access the size and address of Expansion Rom of Nvidia 8400 graphic card.
So in my code, I use the following function:
pci_fill_info(pci_dev, PCI_FILL_IRQ | PCI_FILL_BASES | PCI_FILL_ROM_BASE |
PCI_FILL_SIZES);
When I use pci_dev->rom_base_addr, pci_dev->rom_size to get Expansion
Rom''s size and address, unfortunately it return 0x00.
I have tried to find the root of this problem, I use
[root@localhost ~]# lspci -v -xxx -s 3:0.0
03:00.0 VGA compatible controller: nVidia Corporation Unknown device 0422 (rev
a1) (prog-if 00 [VGA])
Subsystem: nVidia Corporation Unknown device 0523
Flags: fast devsel, IRQ 16
Memory at c2000000 (32-bit, non-prefetchable) [disabled] [size=16M]
Memory at e0000000 (64-bit, prefetchable) [disabled] [size=256M]
Memory at c0000000 (64-bit, non-prefetchable) [disabled] [size=32M]
I/O ports at 2000 [disabled] [size=128]
Expansion ROM at <ignored> [disabled]
Capabilities: [60] Power Management version 2
Capabilities: [68] Message Signalled Interrupts: 64bit+ Queue=0/0
Enable-
Capabilities: [78] Express Endpoint IRQ 0
00: de 10 22 04 00 00 10 00 a1 00 00 03 10 00 00 00
10: 00 00 00 c2 0c 00 00 e0 00 00 00 00 04 00 00 c0
20: 00 00 00 00 01 20 00 00 00 00 00 00 de 10 23 05
30: 00 00 fe ff 60 00 00 00 00 00 00 00 0b 01 00 00
40: de 10 23 05 00 00 00 00 00 00 00 00 00 00 00 00
50: 01 00 00 00 01 00 00 00 ce d6 23 00 00 00 00 00
60: 01 68 02 00 00 00 00 00 05 78 80 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 10 00 01 00 e0 84 00 00
80: 10 28 00 00 01 3d 01 00 48 00 01 11 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
f0: 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
As marked as red, the Expansion Rom address of configuration address has value,
but in general information it shows ignored?
Why does this problem happen? Can anybody give me some suggestions?
Thanks in advance.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel