Xen devel - Mar 2009 - [PATCH] xend: Fix removing /vm/UUID/device paths when device cannot be disconnected v2

Hi,

This is a corrected version of a patch commited as c/s 19250 and reverted by
c/s 19314. Thanks to "trap sigerr ERR" in xen-hotplug-common.sh the
xen-hotplug-cleanup would exit when reading /local/domain/ID/vm fails thus
skipping all the xenstore-rm lines in the rest of the script. Sorry for the
troubles the original patch caused...


Change deviceDestroy behavior to remove /vm/UUID/device/...
path only when force was used (as it already does so for both frontend
and backend) and do the removing from xen-hotplug-cleanup script when we
are sure the device is really not attached to the guest any more.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> This is a corrected version of a patch commited as c/s 19250 and reverted
by
> c/s 19314. Thanks to "trap sigerr ERR" in xen-hotplug-common.sh
the
> xen-hotplug-cleanup would exit when reading /local/domain/ID/vm fails thus
> skipping all the xenstore-rm lines in the rest of the script. Sorry for the
> troubles the original patch caused...
Hi Jiri,
Did you also notice after claim_lock() returns, the ERR trap handler is 
still "sigerr" instead of the one registered inside claim_lock: 
"release_lock $1; sigerr"? I guess it only takes effect within the
scope
of a function. Can shell experts give an explanation here?:)

If so, claim_lock never works as it meant to be, and we will have 
potential issue as it''s widely used.

Thanks,
xiaowei

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel