Joe Jin
2009-Mar-03 06:46 UTC
[Xen-devel] [patch 1/1] hypervisor: Enable hypervisor detect pvhvm running on COMPAT mode
Hi,
When 32bit pvhvm running on 64bit hypervisor, if guest OS create
event-channel more than 32, Domain0 maybe could not communication
with guest OS via new event-channel, also xenwatch thread state
is TASK_UNINTERRUPTIBLE and could not got schedule, all inter-domain
command almost no response.
How to reproduce:
Try to with "xm block-attach" attach more disk to the pvhvm
guest, the issue will appear.
This caused by hypervisor could not probe and decide if pvhvm guest
running in COMPAT mode, and could set the right bits for guest os.
Please review, thanks.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -r 98d48f7680db xen/include/asm-x86/domain.h
--- a/xen/include/asm-x86/domain.h Wed Nov 19 19:13:22 2008 +0000
+++ b/xen/include/asm-x86/domain.h Tue Mar 03 14:35:19 2009 +0800
@@ -16,7 +16,7 @@
#define is_pv_32on64_domain(d) (0)
#endif
#define is_pv_32on64_vcpu(v) (is_pv_32on64_domain((v)->domain))
-#define IS_COMPAT(d) (is_pv_32on64_domain(d))
+#define IS_COMPAT(d) (is_pv_32on64_domain(d) || has_32bit_shinfo(d))
struct trap_bounce {
uint32_t error_code;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2009-Mar-03 09:06 UTC
[Xen-devel] Re: [patch 1/1] hypervisor: Enable hypervisor detect pvhvm running on COMPAT mode
Thanks, I''ll check in a clearer version of this. -- Keir On 03/03/2009 06:46, "Joe Jin" <joe.jin@oracle.com> wrote:> Hi, > > When 32bit pvhvm running on 64bit hypervisor, if guest OS create > event-channel more than 32, Domain0 maybe could not communication > with guest OS via new event-channel, also xenwatch thread state > is TASK_UNINTERRUPTIBLE and could not got schedule, all inter-domain > command almost no response. > > How to reproduce: > Try to with "xm block-attach" attach more disk to the pvhvm > guest, the issue will appear. > > This caused by hypervisor could not probe and decide if pvhvm guest > running in COMPAT mode, and could set the right bits for guest os. > > Please review, thanks. > > Signed-off-by: Joe Jin <joe.jin@oracle.com> > --- > > domain.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -r 98d48f7680db xen/include/asm-x86/domain.h > --- a/xen/include/asm-x86/domain.h Wed Nov 19 19:13:22 2008 +0000 > +++ b/xen/include/asm-x86/domain.h Tue Mar 03 14:35:19 2009 +0800 > @@ -16,7 +16,7 @@ > #define is_pv_32on64_domain(d) (0) > #endif > #define is_pv_32on64_vcpu(v) (is_pv_32on64_domain((v)->domain)) > -#define IS_COMPAT(d) (is_pv_32on64_domain(d)) > +#define IS_COMPAT(d) (is_pv_32on64_domain(d) || > has_32bit_shinfo(d)) > > struct trap_bounce { > uint32_t error_code; > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Mar-03 13:18 UTC
[Xen-devel] Re: [patch 1/1] hypervisor: Enable hypervisor detect pvhvm running on COMPAT mode
On 03/03/2009 06:46, "Joe Jin" <joe.jin@oracle.com> wrote:> When 32bit pvhvm running on 64bit hypervisor, if guest OS create > event-channel more than 32, Domain0 maybe could not communication > with guest OS via new event-channel, also xenwatch thread state > is TASK_UNINTERRUPTIBLE and could not got schedule, all inter-domain > command almost no response. > > How to reproduce: > Try to with "xm block-attach" attach more disk to the pvhvm > guest, the issue will appear. > > This caused by hypervisor could not probe and decide if pvhvm guest > running in COMPAT mode, and could set the right bits for guest os. > > Please review, thanks.I checked in a larger but nicer patch as c/s 19266. Please test it. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Joe Jin
2009-Mar-04 08:00 UTC
[Xen-devel] Re: [patch 1/1] hypervisor: Enable hypervisor detect pvhvm running on COMPAT mode
> > I checked in a larger but nicer patch as c/s 19266. Please test it.Thanks, just do a sample test and looked like it working fine, will try to do more testing! Joe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Joe Jin
2009-Mar-05 01:37 UTC
Re: [Xen-devel] Re: [patch 1/1] hypervisor: Enable hypervisor detect pvhvm running on COMPAT mode
On 2009-03-03 13:18, Keir Fraser wrote:> On 03/03/2009 06:46, "Joe Jin" <joe.jin@oracle.com> wrote: > > > When 32bit pvhvm running on 64bit hypervisor, if guest OS create > > event-channel more than 32, Domain0 maybe could not communication > > with guest OS via new event-channel, also xenwatch thread state > > is TASK_UNINTERRUPTIBLE and could not got schedule, all inter-domain > > command almost no response. > > > > How to reproduce: > > Try to with "xm block-attach" attach more disk to the pvhvm > > guest, the issue will appear. > > > > This caused by hypervisor could not probe and decide if pvhvm guest > > running in COMPAT mode, and could set the right bits for guest os. > > > > Please review, thanks. > > I checked in a larger but nicer patch as c/s 19266. Please test it. > > -- Keir >Bhanu''s test have finished and it working fine, Thanks. Joe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel