Hi, cleaning the source tree fails. gmake tries to enter a non-existing directory. gmake[2]: Entering directory `xen-staging.hg/stubdom/c'' rm -f *.a *.o gmake[2]: Leaving directory `xen-staging.hg/stubdom/c'' gmake -C grub clean gmake[2]: Entering directory `xen-staging.hg/stubdom/grub'' rm -fr dirs *.a *.o stage2 netboot gmake[2]: Leaving directory `xen-staging.hg/stubdom/grub'' gmake -C libxc clean gmake: Entering an unknown directory gmake: *** libxc: No such file or directory. Stop. gmake: Leaving an unknown directory gmake[1]: *** [clean] Error 2 gmake[1]: Leaving directory `xen-staging.hg/stubdom'' gmake: *** [distclean] Error 2 -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :> gmake: *** libxc: No such file or directory. Stop.Ah, right. Samuel stubdom: fix clean target after distclean Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com> diff -r 3dedb6209991 stubdom/Makefile --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100 +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100 @@ -321,8 +321,8 @@ clean: $(MAKE) -C caml clean $(MAKE) -C c clean $(MAKE) -C grub clean - $(MAKE) -C libxc clean - $(MAKE) -C ioemu clean + [ ! -d libxc ] || $(MAKE) -C libxc clean + [ ! -d ioemu ] || $(MAKE) -C ioemu clean # clean the cross-compilation result .PHONY: crossclean _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 01 August 2008 16:18:20 Samuel Thibault wrote:> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit : > > gmake: *** libxc: No such file or directory. Stop. > > Ah, right. > > Samuel > > > stubdom: fix clean target after distclean > > Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com> > > diff -r 3dedb6209991 stubdom/Makefile > --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100 > +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100 > @@ -321,8 +321,8 @@ clean: > $(MAKE) -C caml clean > $(MAKE) -C c clean > $(MAKE) -C grub clean > - $(MAKE) -C libxc clean > - $(MAKE) -C ioemu clean > + [ ! -d libxc ] || $(MAKE) -C libxc clean > + [ ! -d ioemu ] || $(MAKE) -C ioemu clean > > # clean the cross-compilation result > .PHONY: crosscleanYes, this patch works. Tnx. Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir: In c/s 18211, why $$(MAKE) instead of $(MAKE) ? Christoph On Friday 01 August 2008 16:26:33 Christoph Egger wrote:> On Friday 01 August 2008 16:18:20 Samuel Thibault wrote: > > Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit : > > > gmake: *** libxc: No such file or directory. Stop. > > > > Ah, right. > > > > Samuel > > > > > > stubdom: fix clean target after distclean > > > > Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com> > > > > diff -r 3dedb6209991 stubdom/Makefile > > --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100 > > +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100 > > @@ -321,8 +321,8 @@ clean: > > $(MAKE) -C caml clean > > $(MAKE) -C c clean > > $(MAKE) -C grub clean > > - $(MAKE) -C libxc clean > > - $(MAKE) -C ioemu clean > > + [ ! -d libxc ] || $(MAKE) -C libxc clean > > + [ ! -d ioemu ] || $(MAKE) -C ioemu clean > > > > # clean the cross-compilation result > > .PHONY: crossclean > > Yes, this patch works. Tnx. > > Christoph-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Oops. Cut-n-paste error after the patch didn''t apply straight from the email text. Fixed. -- Keir On 1/8/08 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Keir: In c/s 18211, why $$(MAKE) instead of $(MAKE) ? > > Christoph > > > On Friday 01 August 2008 16:26:33 Christoph Egger wrote: >> On Friday 01 August 2008 16:18:20 Samuel Thibault wrote: >>> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit : >>>> gmake: *** libxc: No such file or directory. Stop. >>> >>> Ah, right. >>> >>> Samuel >>> >>> >>> stubdom: fix clean target after distclean >>> >>> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com> >>> >>> diff -r 3dedb6209991 stubdom/Makefile >>> --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100 >>> +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100 >>> @@ -321,8 +321,8 @@ clean: >>> $(MAKE) -C caml clean >>> $(MAKE) -C c clean >>> $(MAKE) -C grub clean >>> - $(MAKE) -C libxc clean >>> - $(MAKE) -C ioemu clean >>> + [ ! -d libxc ] || $(MAKE) -C libxc clean >>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean >>> >>> # clean the cross-compilation result >>> .PHONY: crossclean >> >> Yes, this patch works. Tnx. >> >> Christoph > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Samuel Thibault wrote:> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit : > >> gmake: *** libxc: No such file or directory. Stop. >> > > Ah, right. > > Samuel > > > > stubdom: fix clean target after distclean > > Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com> > > diff -r 3dedb6209991 stubdom/Makefile > --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100 > +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100 > @@ -321,8 +321,8 @@ clean: > $(MAKE) -C caml clean > $(MAKE) -C c clean > $(MAKE) -C grub clean > - $(MAKE) -C libxc clean > - $(MAKE) -C ioemu clean > + [ ! -d libxc ] || $(MAKE) -C libxc clean > + [ ! -d ioemu ] || $(MAKE) -C ioemu clean >Are you sure you don''t not need a double negative there? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :> >+ [ ! -d libxc ] || $(MAKE) -C libxc clean > >+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean > > Are you sure you don''t not need a double negative there?Mmm, why? The clean target succeeds if either there is not even libxc/ioemu directories, or the make clean there works. Samuel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Samuel Thibault wrote:> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit : > >>> + [ ! -d libxc ] || $(MAKE) -C libxc clean >>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean >>> >> Are you sure you don''t not need a double negative there? >> > > Mmm, why? The clean target succeeds if either there is not even > libxc/ioemu directories, or the make clean there works. >I''m just pointing out that [ -d libxc ] && $(MAKE) -C libxc clean is more straightforward. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :> Samuel Thibault wrote: > >Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit : > > > >>>+ [ ! -d libxc ] || $(MAKE) -C libxc clean > >>>+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean > >>> > >>Are you sure you don''t not need a double negative there? > >> > > > >Mmm, why? The clean target succeeds if either there is not even > >libxc/ioemu directories, or the make clean there works. > > > > I''m just pointing out that > > [ -d libxc ] && $(MAKE) -C libxc clean > > is more straightforward.But it makes the rule fail if the directory doesn''t exist. Samuel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Samuel Thibault wrote:> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit : > >> Samuel Thibault wrote: >> >>> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit : >>> >>> >>>>> + [ ! -d libxc ] || $(MAKE) -C libxc clean >>>>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean >>>>> >>>>> >>>> Are you sure you don''t not need a double negative there? >>>> >>>> >>> Mmm, why? The clean target succeeds if either there is not even >>> libxc/ioemu directories, or the make clean there works. >>> >>> >> I''m just pointing out that >> >> [ -d libxc ] && $(MAKE) -C libxc clean >> >> is more straightforward. >> > > But it makes the rule fail if the directory doesn''t exist. >Blerk. OK. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel