Brendan Cully
2007-Jan-31 19:05 UTC
[Xen-devel] [PATCH] Make sure OptVals.quiet is always present (fixes xm shutdown -w)
# HG changeset patch # User Brendan Cully <brendan@cs.ubc.ca> # Date 1170270336 28800 # Node ID 71279ab82d3d5fcbc93179443fe08157264b6dc1 # Parent 68d66b82f05ab54e9c23043bf752200f0063a324 Make sure OptVals.quiet is always present (fixes xm shutdown -w). Signed-off-by: Brendan Cully <brendan@cs.ubc.ca> diff -r 68d66b82f05a -r 71279ab82d3d tools/python/xen/xm/opts.py --- a/tools/python/xen/xm/opts.py Wed Jan 31 10:50:40 2007 -0800 +++ b/tools/python/xen/xm/opts.py Wed Jan 31 11:05:36 2007 -0800 @@ -250,7 +250,8 @@ class OptVals: class OptVals: """Class to hold option values. """ - pass + def __init__(self): + self.quiet = False class Opts: """Container for options. @@ -276,7 +277,6 @@ class Opts: self.argv = [] # Option values. self.vals = OptVals() - self.vals.quiet = 0 # Variables for default scripts. self.vars = {} # Option to use for bare words. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Brendan Cully
2007-Feb-05 23:56 UTC
Re: [Xen-devel] [PATCH] Make sure OptVals.quiet is always present (fixes xm shutdown -w)
On Wednesday, 31 January 2007 at 11:05, Brendan Cully wrote:> # HG changeset patch > # User Brendan Cully <brendan@cs.ubc.ca> > # Date 1170270336 28800 > # Node ID 71279ab82d3d5fcbc93179443fe08157264b6dc1 > # Parent 68d66b82f05ab54e9c23043bf752200f0063a324 > Make sure OptVals.quiet is always present (fixes xm shutdown -w). > > Signed-off-by: Brendan Cully <brendan@cs.ubc.ca>I get a reliable traceback every time I use xm shutdown -w (without this patch). Is anyone else seeing this? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2007-Feb-06 15:33 UTC
Re: [Xen-devel] [PATCH] Make sure OptVals.quiet is always present (fixes xm shutdown -w)
On Wed, Jan 31, 2007 at 11:05:48AM -0800, Brendan Cully wrote:> # HG changeset patch > # User Brendan Cully <brendan@cs.ubc.ca> > # Date 1170270336 28800 > # Node ID 71279ab82d3d5fcbc93179443fe08157264b6dc1 > # Parent 68d66b82f05ab54e9c23043bf752200f0063a324 > Make sure OptVals.quiet is always present (fixes xm shutdown -w). > > Signed-off-by: Brendan Cully <brendan@cs.ubc.ca>Applied, thanks. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel