This piece of code is redundant: (tools/libxc/xc_hvm_bulid.c) function setup_guest() """ if ( (v_end - v_start) > ((unsigned long long)nr_pages << PAGE_SHIFT) ) { PERROR("Initial guest OS requires too much space: " "(%lluMB is greater than %lluMB limit)\n", (unsigned long long)(v_end - v_start) >> 20, ((unsigned long long)nr_pages << PAGE_SHIFT) >> 20); goto error_out; } """ Both of the expressions will always have the same value :) Guy Zana. ____________ Team Leader, Neocleus, Inc. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel