Horms
2007-Jan-10 08:24 UTC
[Xen-devel] [PATCH] kexec/kdump: remove unnecessary incusion of asm/fixmap.h
I think this a legacy of an older revision of this code,
but asm/fixmap.h does not seem to be needed in
asm-x86/x86_32/kexec.h or asm-x86/x86_64/kexec.h
That is, neither of these incarntations of kexec.h seem
to do anything related to fixmap directly or indirectly.
Signed-off-by: Simon Horman <horms@verge.net.au>
--- 0001/xen/include/asm-x86/x86_32/kexec.h
+++ 0016/xen/include/asm-x86/x86_32/kexec.h
@@ -10,7 +10,6 @@
#include <xen/types.h>
#include <xen/kexec.h>
-#include <asm/fixmap.h>
typedef asmlinkage void (*relocate_new_kernel_t)(
unsigned long indirection_page,
--- 0001/xen/include/asm-x86/x86_64/kexec.h
+++ 0016/xen/include/asm-x86/x86_64/kexec.h
@@ -10,7 +10,6 @@
#include <xen/types.h>
#include <xen/kexec.h>
-#include <asm/fixmap.h>
typedef void (*relocate_new_kernel_t)(
unsigned long indirection_page,
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2007-Jan-10 09:40 UTC
[Xen-devel] Re: [PATCH] kexec/kdump: remove unnecessary incusion of asm/fixmap.h
On Wed, 2007-01-10 at 17:24 +0900, Horms wrote:> I think this a legacy of an older revision of this code, > but asm/fixmap.h does not seem to be needed in > asm-x86/x86_32/kexec.h or asm-x86/x86_64/kexec.h > > That is, neither of these incarntations of kexec.h seem > to do anything related to fixmap directly or indirectly. > > Signed-off-by: Simon Horman <horms@verge.net.au>Applied, thanks. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Horms
2007-Jan-11 03:36 UTC
[Xen-devel] Re: [PATCH] kexec/kdump: remove unnecessary incusion of asm/fixmap.h
On Wed, Jan 10, 2007 at 09:40:34AM +0000, Ian Campbell wrote:> On Wed, 2007-01-10 at 17:24 +0900, Horms wrote: > > I think this a legacy of an older revision of this code, > > but asm/fixmap.h does not seem to be needed in > > asm-x86/x86_32/kexec.h or asm-x86/x86_64/kexec.h > > > > That is, neither of these incarntations of kexec.h seem > > to do anything related to fixmap directly or indirectly. > > > > Signed-off-by: Simon Horman <horms@verge.net.au> > > Applied, thanks.Thanks -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel