Daniel P. Berrange
2008-Jul-11 11:32 UTC
[Xen-devel] PATCH: Ignore errors from dieing domains in RPC server
When a domain is in the process of shutting down there is a small window when the domain is known to XenD, but it will be unable to form an SXPR for it due it being in the middle of device hot-unplug. This causes the ''xm list'' command to totally fail with an error like # xm list Error: Device 0 not connected Usage: xm list [options] [Domain, ...] List information about all/some domains. -l, --long Output all VM details in SXP --label Include security labels The ''xm list'' command calls into the ''domains'' method of XMLRPCServer.py in XenD. This method just iterates over the list of domains, fetching the sxpr for each in turn, but with no exception handling. So if a single domain fails to generate an sxpr, no data is returned even for other domains which are still functional. This patch simply makes XenD ignore and skip over domains which throw an exception, logging the problematic domain. NB, this problem only hits ''xm list'' if it is configured to use the legay XMLRPC server instead of XenAPI. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> diff -r 27aaff984b36 tools/python/xen/xend/server/XMLRPCServer.py --- a/tools/python/xen/xend/server/XMLRPCServer.py Thu Jul 10 17:33:23 2008 +0100 +++ b/tools/python/xen/xend/server/XMLRPCServer.py Fri Jul 11 12:28:02 2008 +0100 @@ -64,7 +64,14 @@ def domains_with_state(detail, state, full): if detail: domains = XendDomain.instance().list_sorted(state) - return map(lambda dom: fixup_sxpr(dom.sxpr(not full)), domains) + ret = [] + for dom in domains: + try: + ret.append(fixup_sxpr(dom.sxpr(not full))) + except: + log.warn("Failed to query SXPR for domain %s" % str(dom)) + pass + return ret else: return XendDomain.instance().list_names(state) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Apparently Analagous Threads
- xend and xen-tool crashed after intensive operation
- Loss of hypervisor control - xm, xentop
- Bug#744163: xenstore problems
- Creating domU failed with "xenconsole: xs_get_domain_path(): No such file or directory"
- Re: [Xen-changelog] Improve error handling, in particular fixing the ProtocolError that is thrown