I pulled in the latest changes after seeing the Changelog Digests go by - but seem to be having problems compiling against the latest 2.6.18-xen kernel changeset (523:f128849f9e78) http://xenbits.xensource.com/linux-2.6.18-xen.hg?rev/f128849f9e78 xen-changelog-request@lists.xensource.com wrote:> 6. [linux-2.6.18-xen] linux/x86: set up machine_e820 in > copy_e820_map() for it to be usable (Xen patchbot-linux-2.6.18-xen) > > ---------------------------------------------------------------------- >This is the chunk of the patch that is giving me problems: (errors below)> + > +#ifdef CONFIG_XEN > + if (is_initial_xendomain()) { > + struct xen_memory_map memmap; > + > + memmap.nr_entries = E820MAX; > + set_xen_guest_handle(memmap.buffer, machine_e820.map); > + > + if (HYPERVISOR_memory_op(XENMEM_machine_memory_map, &memmap)) > + BUG(); > + machine_e820.nr_map = memmap.nr_entries; > + } else > + machine_e820 = e820; > +#endif > + > return 0; > } >CC arch/x86_64/kernel/e820.o /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c: In function ‘copy_e820_map’: /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:613: error: ‘machine_e820’ undeclared (first use in this function) /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:613: error: (Each undeclared identifier is reported only once /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:613: error: for each function it appears in.) Is this changeset complete - or did an extern declaration get left out somehow? Ben Guthro _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Apr-22 17:47 UTC
Re: [Xen-devel] Re: Xen-changelog Digest, Vol 38, Issue 55
Easily fixed. I''ll sort it out and push it through to the public tree. Thanks, Keir On 22/4/08 18:19, "Ben Guthro" <bguthro@virtualiron.com> wrote:> I pulled in the latest changes after seeing the Changelog Digests go by > - but seem to be having problems > compiling against the latest 2.6.18-xen kernel changeset (523:f128849f9e78) > http://xenbits.xensource.com/linux-2.6.18-xen.hg?rev/f128849f9e78 > > xen-changelog-request@lists.xensource.com wrote: >> 6. [linux-2.6.18-xen] linux/x86: set up machine_e820 in >> copy_e820_map() for it to be usable (Xen patchbot-linux-2.6.18-xen) >> >> ---------------------------------------------------------------------- >> > This is the chunk of the patch that is giving me problems: (errors below) >> + >> +#ifdef CONFIG_XEN >> + if (is_initial_xendomain()) { >> + struct xen_memory_map memmap; >> + >> + memmap.nr_entries = E820MAX; >> + set_xen_guest_handle(memmap.buffer, machine_e820.map); >> + >> + if (HYPERVISOR_memory_op(XENMEM_machine_memory_map, &memmap)) >> + BUG(); >> + machine_e820.nr_map = memmap.nr_entries; >> + } else >> + machine_e820 = e820; >> +#endif >> + >> return 0; >> } >> > CC arch/x86_64/kernel/e820.o > /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c: > In function copy_e820_map¹: > /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:6 > 13: > error: machine_e820¹ undeclared (first use in this function) > /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:6 > 13: > error: (Each undeclared identifier is reported only once > /home/bguthro/dev/unstable/linux-2.6.18-xen.hg/arch/x86_64/kernel/e820-xen.c:6 > 13: > error: for each function it appears in.) > > > > Is this changeset complete - or did an extern declaration get left out > somehow? > > Ben Guthro > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel