Jan Beulich
2005-Aug-22 08:13 UTC
[Xen-devel] [PATCH] fix another out-of-source-tree xenlinux build problem
Signed-off-by: Jan Beulich <jbeulich@novell.com> Index: xen-2005-08-19/arch/xen/x86_64/ia32/Makefile ==================================================================--- xen-2005-08-19.orig/arch/xen/x86_64/ia32/Makefile 2005-08-19 19:57:45.797961680 +0200 +++ xen-2005-08-19/arch/xen/x86_64/ia32/Makefile 2005-08-19 20:19:02.000000000 +0200 @@ -36,8 +36,8 @@ $(call if_changed,syscall) AFLAGS_vsyscall-int80.o = -m32 -I$(obj) -AFLAGS_vsyscall-sysenter.o = -m32 -AFLAGS_vsyscall-syscall.o = -m32 +AFLAGS_vsyscall-sysenter.o = -m32 -I$(obj) +AFLAGS_vsyscall-syscall.o = -m32 -I$(obj) CFLAGS_ia32_ioctl.o += -Ifs/ s-link := vsyscall-syscall.o vsyscall-sysenter.o vsyscall-sigreturn.o @@ -48,13 +48,11 @@ $(patsubst %.o,$(obj)/%.c,$(c-obj-y) $(c-link)) $(patsubst %.o,$(obj)/%.S,$(s-obj-y) $(s-link)): @ln -fsn $(srctree)/arch/x86_64/ia32/$(notdir $@) $@ -$(obj)/vsyscall-int80.S: $(obj)/vsyscall-sigreturn.S ../../i386/kernel/vsyscall-note.S -$(obj)/vsyscall-sysenter.S: $(obj)/vsyscall-sigreturn.S -$(obj)/vsyscall-syscall.S: $(obj)/vsyscall-sigreturn.S - -../../i386/kernel/vsyscall-note.S: - @ln -fsn $(srctree)/arch/i386/kernel/$(notdir $@) $(srctree)/arch/xen/i386/kernel/$(notdir $@) - make -C arch/xen/i386/kernel vsyscall-note.S +$(obj)/vsyscall-int80.o $(obj)/vsyscall-sysenter.o $(obj)/vsyscall-syscall.o: \ + $(obj)/vsyscall-sigreturn.S $(obj)/../../i386/kernel/vsyscall-note.S + +$(obj)/../../i386/kernel/vsyscall-note.S: + @ln -fsn $(srctree)/arch/i386/kernel/$(notdir $@) $@ obj-y += $(c-obj-y) $(s-obj-y) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Aug-22 09:00 UTC
Re: [Xen-devel] [PATCH] fix another out-of-source-tree xenlinux build problem
On 22 Aug 2005, at 09:13, Jan Beulich wrote:> AFLAGS_vsyscall-int80.o = -m32 -I$(obj) > -AFLAGS_vsyscall-sysenter.o = -m32 > -AFLAGS_vsyscall-syscall.o = -m32 > +AFLAGS_vsyscall-sysenter.o = -m32 -I$(obj) > +AFLAGS_vsyscall-syscall.o = -m32 -I$(obj)How come native out-of-tree builds don''t require this patch? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2005-Aug-22 09:13 UTC
Re: [Xen-devel] [PATCH] fix another out-of-source-tree xenlinux build problem
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 22.08.05 11:00:33 >>> > >On 22 Aug 2005, at 09:13, Jan Beulich wrote: > >> AFLAGS_vsyscall-int80.o = -m32 -I$(obj) >> -AFLAGS_vsyscall-sysenter.o = -m32 >> -AFLAGS_vsyscall-syscall.o = -m32 >> +AFLAGS_vsyscall-sysenter.o = -m32 -I$(obj) >> +AFLAGS_vsyscall-syscall.o = -m32 -I$(obj) > >How come native out-of-tree builds don''t require this patch?Because they don''t use the symbolic link mechanism xenlinux uses; these symbolic links are created in the objtree (or if they don''t, as I found in some cases, their rules need to be changed, since srctree should never be touched). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Aug-22 09:46 UTC
Re: [Xen-devel] [PATCH] fix another out-of-source-tree xenlinux build problem
On 22 Aug 2005, at 10:13, Jan Beulich wrote:>> How come native out-of-tree builds don''t require this patch? > > Because they don''t use the symbolic link mechanism xenlinux uses; these > symbolic links are created in the objtree (or if they don''t, as I found > in some cases, their rules need to be changed, since srctree should > never be touched).Okay, that makes sense. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel