Chen, Huacai
2008-Mar-18 02:03 UTC
[Xen-devel] [PATCH] Fix a bug when ACPI registers in System_Memory
Hi, all, Some ACPI registers may be in System_Memory but not System_IO space, For these machines S3 fails since current Xen use I/O instructions (e.g. inb(), outb(), etc.) to access ACPI registers. The patch attached fix the bug by adding GAS (generic address structure) support ported from Linux, which should also benefit later ACPI activity within Xen. Best regards, Huacai Chen Signed-off-by: Huacai Chen <huacai.chen@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Mar-18 14:57 UTC
Re: [Xen-devel] [PATCH] Fix a bug when ACPI registers in System_Memory
I¹ve done a more comprehensive update of the Xen ACPI header files (upgraded to Linux 2.6.24). Please re-work your patch against changeset 17231 in xen-unstable staging tree. Avoid changing any header files under xen/include/acpi/ unless you have good reason. Where you take new files from Linux, please use Linux 2.6.24 or newer. Thanks, Keir On 18/3/08 02:03, "Chen, Huacai" <huacai.chen@intel.com> wrote:> Hi, all, > > Some ACPI registers may be in System_Memory but not System_IO space, For these > machines S3 fails since current Xen use I/O instructions (e.g. inb(), outb(), > etc.) to access ACPI registers. The patch attached fix the bug by adding GAS > (generic address structure) support ported from Linux, which should also > benefit later ACPI activity within Xen. > > Best regards, > Huacai Chen > > Signed-off-by: Huacai Chen <huacai.chen@intel.com> > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Chen, Huacai
2008-Mar-19 07:33 UTC
RE: [Xen-devel] [PATCH] Fix a bug when ACPI registers in System_Memory
Hi, Keir, This is a new version of the patch, it works on changeset 17243. None of the header files under xen/include/acpi has changed this time, and all ported functions are from Linux 2.6.24.2. Best regards, Huacai Chen ________________________________ From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: 2008年3月18日 22:57 To: Chen, Huacai; xen-devel@lists.xensource.com Subject: Re: [Xen-devel] [PATCH] Fix a bug when ACPI registers in System_Memory I’ve done a more comprehensive update of the Xen ACPI header files (upgraded to Linux 2.6.24). Please re-work your patch against changeset 17231 in xen-unstable staging tree. Avoid changing any header files under xen/include/acpi/ unless you have good reason. Where you take new files from Linux, please use Linux 2.6.24 or newer. Thanks, Keir On 18/3/08 02:03, "Chen, Huacai" <huacai.chen@intel.com> wrote: Hi, all, Some ACPI registers may be in System_Memory but not System_IO space, For these machines S3 fails since current Xen use I/O instructions (e.g. inb(), outb(), etc.) to access ACPI registers. The patch attached fix the bug by adding GAS (generic address structure) support ported from Linux, which should also benefit later ACPI activity within Xen. Best regards, Huacai Chen Signed-off-by: Huacai Chen <huacai.chen@intel.com> ________________________________ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel